[GOG]: Switch to Galaxy way of loading library #2759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
additionally added releveant types
CacheStores now allow to enable temporal in-memory cache useful for many operations preventing IO blocking
|
This PR also removes duplicated |
currently it's only used in GOG games that don't support any content system (goodies). If game couldn't be found in products API it's assumed it's not installable
imLinguin
added
pr:testing
imLinguin
requested review from
a team,
arielj,
flavioislima,
CommandMC and
Nocccer
and removed request for
a team
|
New
|
public/locales/en/gamepage.json
Outdated
| @@ -133,6 +133,7 @@ | |||
| }, | |||
| "label": { | |||
| "game": { | |||
| "not-installable-game": "", | |||
There was a problem hiding this comment.
Maybe add a default text here.
| @@ -80,7 +81,7 @@ export async function getExtraInfo(appName: string): Promise<ExtraInfo> { | |||
| const extra: ExtraInfo = { | |||
| about: gameInfo.extra?.about, | |||
| reqs: await createReqsArray(appName, targetPlatform), | |||
| storeUrl: gameInfo.store_url | |||
| storeUrl: (await getGamesData(appName))?._links.store.href | |||
There was a problem hiding this comment.
I know this works, nice. But I still think that we should solve promises before defining the values of this object, for both this and the previous key.
It is more readable and safer imo.
flavioislima
approved these changes
Jun 12, 2023
|
@imLinguin I think this one is fine to merge if you want to. |
|
Oh, yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test of trying to replicate how GOG Galaxy loads the library.
We achieve this using galaxy-library endpoint which contains games from all connected integrations (updated by client), and GOG (updated internally). We filter out all the gog games and use those.
If we decided to go hardcore we could maybe support those integrations in the future in some way.
Of course this can be further extended in terms of caching and deciding whether to fetch new data for games.
One proposition is to verify if we have up to date data when opening the game page.
For now I'm marking it as wip (library pagination is still to be done)Additionally the galaxy-library endpoint provides us with certificates that somehow in pair with GOG access token allow us to get data from gamesdb that would return 404 otherwise.
Additionally I reduced IO traffic when pulling the library thanks to allowing to temporarily offload the CacheStore to memory, and then sync it to drive after all operations.
This PR also adds new field
installableto GameInfo. Preventing Cannot get game info errors for goodie packs.Use the following Checklist if you have changed something on the Backend or Frontend: