Skip to content

[Fix] Fixes for 2.6 release #2416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Feb 4, 2023
Merged

[Fix] Fixes for 2.6 release #2416

merged 27 commits into from
Feb 4, 2023

Conversation

flavioislima
Copy link
Member

@flavioislima flavioislima commented Feb 3, 2023


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima requested review from a team, arielj, CommandMC, Nocccer, imLinguin and redromnon and removed request for a team February 3, 2023 12:52
@flavioislima flavioislima added the pr:ready-for-review Feature-complete, ready for the grind! :P label Feb 3, 2023
@flavioislima flavioislima linked an issue Feb 3, 2023 that may be closed by this pull request
@flavioislima flavioislima linked an issue Feb 3, 2023 that may be closed by this pull request
@flavioislima flavioislima linked an issue Feb 3, 2023 that may be closed by this pull request
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested things like the gog downloads for linux, the download size, themes

Things look good to me 👍 (some theme's still have small issues, but I don't think they are critical)

I think we should include an update of gogdl too since many users are having issues downloading games (I made a PR last night for it, I'll wait for linguin to review it)

One small thing to add, can you include an edit of the github issue template mentioning the latest stable to be 2.6.2? like this #2407 (but that one is going to be outdated already)

@flavioislima
Copy link
Member Author

Yes, sure. Will do that on this PR and wait for your fix on gogdl but I think we should release the hotfix today since we have some critical stuff broken.

@arielj
Copy link
Collaborator

arielj commented Feb 4, 2023

Yes, sure. Will do that on this PR and wait for your fix on gogdl but I think we should release the hotfix today since we have some critical stuff broken.

one thing we can do, if the fix is not ready by the time you want to release, we can downgrade gogdl to the commit before the latest, that one works fine

@flavioislima flavioislima merged commit 858272f into main Feb 4, 2023
@flavioislima flavioislima deleted the fix/26_fixes branch February 4, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
2 participants