-
-
Notifications
You must be signed in to change notification settings - Fork 480
[Fix] Fixes for 2.6 release #2416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested things like the gog downloads for linux, the download size, themes
Things look good to me 👍 (some theme's still have small issues, but I don't think they are critical)
I think we should include an update of gogdl too since many users are having issues downloading games (I made a PR last night for it, I'll wait for linguin to review it)
One small thing to add, can you include an edit of the github issue template mentioning the latest stable
to be 2.6.2
? like this #2407 (but that one is going to be outdated already)
Yes, sure. Will do that on this PR and wait for your fix on gogdl but I think we should release the hotfix today since we have some critical stuff broken. |
one thing we can do, if the fix is not ready by the time you want to release, we can downgrade gogdl to the commit before the latest, that one works fine |
Use the following Checklist if you have changed something on the Backend or Frontend: