Skip to content

Themes issues #2410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arielj opened this issue Feb 3, 2023 · 1 comment · Fixed by #2416
Closed

Themes issues #2410

arielj opened this issue Feb 3, 2023 · 1 comment · Fixed by #2416

Comments

@arielj
Copy link
Collaborator

arielj commented Feb 3, 2023

Describe the bug

There are elements in the interface that are always showing the color from the new default instead of the expected color from the there.

Game title in Zombie theme uses the mirage text color
image

(this light blue text color is leaking to a lot of places in many themes)

Same for the search bar
image

Also for Dracula
image

Game Defaults info message is too light in Nord Light:
image

Also Nord Light, current vs not current setting screen is too similar:
image

Dracula settings text color is the one from mirage
image

Same for some of the text in Zombie
image

Sweet accent color is too dark for the sidebar
image

Contrast of yellow button in Mirage is below standards:
image

Sync button in high contrast theme has bad contrast
image

These red buttons in high contrast theme have bad contrast when hovered
image

Same for Nord Light
image

Add logs

nothing relevant

Steps to reproduce

Just try different themes

Expected behavior

Themes should have a consistent color palette. Elements should have at least AA contrast.

Screenshots

No response

Heroic Version

Latest Stable

System Information

Not relevant

Additional information

I don't know if this is the best place to report these issues, there are a lot of really small things.

@flavioislima
Copy link
Member

I have defined some default variables for themes that does not have those, because before we were reusing some colors from the cyber theme.

I am checking this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants