Skip to content

Reorder settings #1984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 3, 2022
Merged

Reorder settings #1984

merged 3 commits into from
Nov 3, 2022

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Nov 3, 2022

This PR moves a lot of things around reordering the settings.

There are a few issues with the current organization:

With this change, I'm aiming to address those with these changes:

  • Everything that is a general Heroic configuration is now in the General Settings section or the Advanced section (we might need to move some things around there)
  • All the global settings that are actually defaults are grouped in a Game Defaults section and the section is divided by subsections (Wine, Wine Extensions, Others). There's also a message at the top of this section indicating that these are defaults and changing them won't affect already installed games
  • When changing the settings of a game, most of the options are in a single screen so users don't have to try the different sections
  • By removing Wine and Wine Extensions from the sidebar, the bug linked above is removed

I have one more idea to add to this, a search box at the top of each setting section to filter settings (like the way chrome://config works).

Any feedback would be great. I know there might be some concerns about the Game Settings section being too long.

Some extra notes:

  • I moved some files around because when moving the settings it was clear the imports would be really messy, now all the individual settings are in Settings/components and each of the sections is in Settings/sections
  • I changed the style of the Run EXE on Prefix button that was breaking the design a lot in the place it's now.
  • most of the changes in the PR diff are just translation files and the individual settings being moved to Settings/components, there's only change change there though, I divided WinePrefix into WinePrefix and WinePrefixesBasePath, it didn't make sense for these 2 settings to be in the same component, one is a game default and the other is a global setting)

Video of how it looks and behaves currently:

settings.mp4

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj requested review from a team, flavioislima, CommandMC, Nocccer, imLinguin and redromnon and removed request for a team November 3, 2022 02:46
Copy link
Collaborator

@CommandMC CommandMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I quite like these changes.
Some oddities I've noticed:

  • In the Game Defaults, the Wine Version dropdown is too short:
    image
  • The spacing of these options looks a bit off:
    image

Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, tested here and everything is working fine. Lets get some feedback from the next beta now :D

@flavioislima flavioislima merged commit a814a2c into beta Nov 3, 2022
@flavioislima flavioislima deleted the feature/reorder-settings branch November 3, 2022 10:16
@flavioislima
Copy link
Member

I quite like these changes. Some oddities I've noticed:

  • In the Game Defaults, the Wine Version dropdown is too short:
    image
  • The spacing of these options looks a bit off:
    image

sorry man, saw your comments only after merging the PR. You are right about those, I can fix on another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants