Skip to content

Settings grouping is not consistent #1696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arielj opened this issue Aug 10, 2022 · 0 comments · Fixed by #1984
Closed

Settings grouping is not consistent #1696

arielj opened this issue Aug 10, 2022 · 0 comments · Fixed by #1984
Labels
enhancement This feature needs upgrades. medium-priority

Comments

@arielj
Copy link
Collaborator

arielj commented Aug 10, 2022

Describe the bug

A user might be confused on why options are in some places. For example, Sync with installed Epic Games is the third option in the General settings but it's not relevant to users that only use GOG, and there's no equivalent option for GOG. Then we have other Epic related settings (like the legendary path and the EOS overlay or the non-https download) in the Advanced settings, but there's a gog binary configuration in the middle and the non-https function I think only applies to Epic.

Maybe we need an Epic and a GOG sections in the settings?

Also, in the Others section there's a mix of toggles that affect default game settings when a game is installed (like show FPS, use GameMode, Pulse Audio fix, env variables, and more) and toggles or settings for heroic's config like automatically creating shorcuts, discord rich presence or add as non-steam configuration. Maybe elements should be moved to other screens or group them more consistently.

In the General settings we have the Max number of workers when downloading that probably works better in the Advanced section.

Add logs

no logs

Steps to reproduce

Navigate Heroic's settings and check the options in each section and you'll see some things seems to be related but are in unrelated places.

Expected behavior

It should be easier for a user to see related options close to each other.

Screenshots

No response

System Information

  • Heroic Version [e. g. 2.1.1]: beta branch

Additional information

No response

@arielj arielj added the enhancement This feature needs upgrades. label Aug 10, 2022
@arielj arielj mentioned this issue Nov 3, 2022
4 tasks
@flavioislima flavioislima linked a pull request Nov 3, 2022 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This feature needs upgrades. medium-priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants