-
-
Notifications
You must be signed in to change notification settings - Fork 480
[Tech] Merge Beta Branch in Main #1811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Added ping to check internet connection * removed console.log * Make log of error more clear * Remove ping package and just use ping cli command * Return if one ping succeed
* Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Translated using Weblate (Czech) Currently translated at 100.0% (358 of 358 strings) Translated using Weblate (Czech) Currently translated at 100.0% (358 of 358 strings) Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: Shimon <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/cs/ Translation: Heroic Games Launcher/GamePage Translation: Heroic Games Launcher/Globals * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Translated using Weblate (Korean) Currently translated at 100.0% (358 of 358 strings) Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: Moon Sungjoon <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/ko/ Translation: Heroic Games Launcher/Globals * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Translated using Weblate (Russian) Currently translated at 100.0% (358 of 358 strings) Translated using Weblate (Russian) Currently translated at 100.0% (358 of 358 strings) Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: Sedative <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/ru/ Translation: Heroic Games Launcher/Globals * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Translated using Weblate (Persian) Currently translated at 100.0% (358 of 358 strings) Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: Parsa Shadab <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/fa/ Translation: Heroic Games Launcher/GamePage Translation: Heroic Games Launcher/Globals * Update translation files Updated by "Squash Git commits" hook in Weblate. Translation: Heroic Games Launcher/Globals Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/ Co-authored-by: Shimon <[email protected]> Co-authored-by: Moon Sungjoon <[email protected]> Co-authored-by: Sedative <[email protected]> Co-authored-by: Parsa Shadab <[email protected]>
…k with strict mode (#1633) * Change complete project structure - Rename "src" -> "src/frontend" - Rename "electron" -> "src/backend" - Move types.ts to "common/types.ts" * Switch from react-scripts + foreman + webpack + ts-loader -> Vite * Set GH_TOKEN and GITHUB_TOKEN in tests directly This just cleans up package.json a bit * Get SVG & JPG importing working in VSCode * Move type definitions into common/typedefs * Fixup tests * Rewrite large chunks of the backend to be compatible with strict mode * Modify frontend to reflect changes to type definition structure * Remove unused files These weren't necessary, at least as far as I can tell * Update translations * Fixup: Re-add `--filesystem` parameter for Proton Turns out refactoring a lot of stuff can introduce issues, who would've thought * Remove `build` script You never have to run this yourself, so it was a bit confusing to have. If you really need its functionality, `vite build` isn't that hard to type in on your own :^) * Fully remove all remnants of UE support * Add new 'codecheck' command This command can be used to make sure that no files in the project violate TS rules, since Vite itself doesn't check them It would probably be a good idea to add them to GH Workflows and/or pre-commit hooks, but I'm not too sure on how to do that * Update translation files * Fix translation files Not sure how this happens, but it seems they've gotten screwed up in the merge * Remove some more unnecessary files * Always get game updates from all libraries This fixes an issue where refreshing the library while only showing one library made the update icons of all the others disappear * Some misc code style changes
fixing not permanently saving downloadNoHttps config option
* remove useEffect double import * catch type error end of json * Added try catch * Add log prefix to see what runner fails
* Add codecheck to pre push and workflow * Add new workflow for codecheck * renaming
Update legendary binaries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What i missing are the changed binaries of legendary?
from my understanding if we merge beta into main, the main binaries should be updated with the binaries from beta ?
I think the binaries are correct, I just tested it and the games are downloading just fine. Check the list of commits, your fix is included on it. |
Merging the changes so we can get the benefits of the Vite implementation and other refactors.
Use the following Checklist if you have changed something on the Backend or Frontend: