[Fix] GOG stuck progress on download + Add 7 new languages #1800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavioislima
requested review from
CommandMC,
imLinguin,
Nocccer and
redromnon
flavioislima
commented
Sep 10, 2022
| @@ -83,18 +89,21 @@ Heroic is built with Web Technologies like: TypeScript, React, NodeJS and Electr | |||
| - French | |||
| - German | |||
| - Greek | |||
| - Japanese | |||
There was a problem hiding this comment.
Japanese was translated but was missing on readme. While Romanian was here but it was not available to select.
flavioislima
commented
Sep 10, 2022
| @@ -343,6 +343,7 @@ function Settings() { | |||
| defaultWinePrefix, | |||
| disableController, | |||
| discordRPC, | |||
| downloadNoHttps, | |||
There was a problem hiding this comment.
this was a new fix in beta that I am adding here as well.
flavioislima
commented
Sep 10, 2022
| @@ -132,8 +132,8 @@ class GOGGame extends Game { | |||
| const etaMatch = data.match(/ETA: (\d\d:\d\d:\d\d)/m) | |||
| const bytesMatch = data.match(/Downloaded: (\S+) MiB/m) | |||
| const progressMatch = data.match(/Progress: (\d+\.\d+) /m) | |||
| if (etaMatch && bytesMatch && progressMatch) { | |||
| const eta = etaMatch[1] | |||
| if (bytesMatch && progressMatch) { | |||
There was a problem hiding this comment.
Removed the eta dependency just in case someone has a pretty slow connection to download a huge game.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the following Checklist if you have changed something on the Backend or Frontend: