Skip to content

[UI] Sidebar settings button opens game settings on GamePage #1579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 15, 2022
Merged

[UI] Sidebar settings button opens game settings on GamePage #1579

merged 8 commits into from
Jul 15, 2022

Conversation

Nocccer
Copy link
Collaborator

@Nocccer Nocccer commented Jul 15, 2022 •
edited
Loading

simplescreenrecorder-2022-07-15_17.39.17.mp4

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@Nocccer Nocccer changed the base branch from main to beta July 15, 2022 15:01
@Nocccer Nocccer mentioned this pull request Jul 15, 2022
Merged
4 tasks
@Nocccer Nocccer changed the title [Fix] Sidebar settings button opens game settings on GamePage [UI] Sidebar settings button opens game settings on GamePage Jul 15, 2022
flavioislima
flavioislima approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff!

@flavioislima flavioislima added the pr:ready-to-merge This PR is fully ready for merge. label Jul 15, 2022
@Nocccer
Copy link
Collaborator Author

Nocccer commented Jul 15, 2022 •
edited
Loading

@CommandMC if you have time, can you check if the error you described in EOS Overlay PR, still happens with this PR?

I couldn't reproduce it.

@CommandMC
Copy link
Collaborator

Nope, doesn't happen anymore

@Nocccer Nocccer merged commit 5dc05b8 into beta Jul 15, 2022
@Nocccer Nocccer deleted the fix/settings branch July 15, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavioislima flavioislima flavioislima approved these changes

@CommandMC CommandMC CommandMC approved these changes

@arielj arielj Awaiting requested review from arielj

Assignees
No one assigned
Labels
pr:ready-to-merge This PR is fully ready for merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nocccer @CommandMC @flavioislima