[UI] Sidebar settings button opens game settings on GamePage (#1579)

* Fix sidebar settings button

* fixes

* lint fix

* Add i18n fallback

* lint fix

* Renamed defaultSettingsPath to settingsPath

* lint fix

Author: Nocccer

public/locales/bg/translation.json

@@ -151,6 +151,7 @@
         "store": "Магазин",
         "title": "Име на играта"
     },
+    "GameSettings": "Game Settings",
     "generic": {
         "error": {
             "component": "Няма намерени игри. Опитайте да излезете и влезете пак с регистрацията си, или пробвайте един от вариантите по-долу"

public/locales/ca/translation.json

@@ -151,6 +151,7 @@
         "store": "Botiga",
         "title": "Títol del joc"
     },
+    "GameSettings": "Game Settings",
     "generic": {
         "error": {
             "component": "No s'han trobat jocs. Proveu a reiniciar la sessió o alguna de les opcions de sota."

public/locales/cs/translation.json

@@ -151,6 +151,7 @@
         "store": "Obchod",
         "title": "Název hry"
     },
+    "GameSettings": "Game Settings",
     "generic": {
         "error": {
             "component": "Nebyly nalezeny žádné hry - Zkuste se znovu odhlásit a přihlásit nebo jednu z níže uvedených možností"

public/locales/de/translation.json

@@ -151,6 +151,7 @@
         "store": "Store",
         "title": "Game Title"
     },
+    "GameSettings": "Game Settings",
     "generic": {
         "error": {
             "component": "Keine Spiele gefunden - Versuchen Sie, sich abzumelden und erneut anzumelden, oder wählen Sie eine der folgenden Optionen"

public/locales/el/translation.json

@@ -151,6 +151,7 @@
         "store": "Store",
         "title": "Game Title"
     },
+    "GameSettings": "Game Settings",
     "generic": {
         "error": {
             "component": "No Games found - Try to logout and login again or one of the options bellow"

public/locales/en/translation.json

@@ -151,6 +151,7 @@
         "store": "Store",
         "title": "Game Title"
     },
+    "GameSettings": "Game Settings",
     "generic": {
         "error": {
             "component": "No Games found - Try to logout and login again or one of the options bellow"

public/locales/es/translation.json

@@ -151,6 +151,7 @@
         "store": "Store",
         "title": "Game Title"
     },
+    "GameSettings": "Game Settings",
     "generic": {
         "error": {
             "component": "No Games found - Try to logout and login again or one of the options bellow"

public/locales/et/translation.json

@@ -151,6 +151,7 @@
         "store": "Pood",
         "title": "Mängu pealkiri"
     },
+    "GameSettings": "Game Settings",
     "generic": {
         "error": {
             "component": "Mänge ei leitud - proovige uuesti sisse logida või ühte allolevatest võimalustest"

public/locales/fa/translation.json

@@ -151,6 +151,7 @@
         "store": "فروشگاه",
         "title": "عنوان بازی"
     },
+    "GameSettings": "Game Settings",
     "generic": {
         "error": {
             "component": "بازی یافت نشد - خروج از حساب و ورود مجدد را امتحان کرده یا یکی از گزینه های زیر را امتحان کنید"

public/locales/fi/translation.json

@@ -151,6 +151,7 @@
         "store": "Store",
         "title": "Game Title"
     },
+    "GameSettings": "Game Settings",
     "generic": {
         "error": {
             "component": "No Games found - Try to logout and login again or one of the options bellow"

public/locales/fr/translation.json

@@ -151,6 +151,7 @@
         "store": "Store",
         "title": "Game Title"
     },
+    "GameSettings": "Game Settings",
     "generic": {
         "error": {
             "component": "No Games found - Try to logout and login again or one of the options bellow"

public/locales/gl/translation.json

@@ -151,6 +151,7 @@
         "store": "Store",
         "title": "Game Title"
     },
+    "GameSettings": "Game Settings",
     "generic": {
         "error": {
             "component": "No Games found - Try to logout and login again or one of the options bellow"

public/locales/hr/translation.json

@@ -151,6 +151,7 @@
         "store": "Store",
         "title": "Game Title"
     },
+    "GameSettings": "Game Settings",
     "generic": {
         "error": {
             "component": "No Games found - Try to logout and login again or one of the options bellow"

public/locales/hu/translation.json

@@ -151,6 +151,7 @@
         "store": "Store",
         "title": "Game Title"
     },
+    "GameSettings": "Game Settings",
     "generic": {
         "error": {
             "component": "No Games found - Try to logout and login again or one of the options bellow"

public/locales/id/translation.json

@@ -151,6 +151,7 @@
         "store": "Toko",
         "title": "Judul Gim"
     },
+    "GameSettings": "Game Settings",
     "generic": {
         "error": {
             "component": "Tidak ada Gim yang ditemukan - Silakan coba log keluar lalu log masuk lagi atau salah satu opsi di bawah ini"

public/locales/it/translation.json

@@ -151,6 +151,7 @@
         "store": "Store",
         "title": "Game Title"
     },
+    "GameSettings": "Game Settings",
     "generic": {
         "error": {
             "component": "No Games found - Try to logout and login again or one of the options bellow"

public/locales/ja/translation.json

@@ -151,6 +151,7 @@
         "store": "Store",
         "title": "Game Title"
     },
+    "GameSettings": "Game Settings",
     "generic": {
         "error": {
             "component": "No Games found - Try to logout and login again or one of the options bellow"

public/locales/ko/translation.json

@@ -151,6 +151,7 @@
         "store": "Store",
         "title": "Game Title"
     },
+    "GameSettings": "Game Settings",
     "generic": {
         "error": {
             "component": "No Games found - Try to logout and login again or one of the options bellow"

public/locales/ml/translation.json

@@ -151,6 +151,7 @@
         "store": "Store",
         "title": "Game Title"
     },
+    "GameSettings": "Game Settings",
     "generic": {
         "error": {
             "component": "No Games found - Try to logout and login again or one of the options bellow"

public/locales/nl/translation.json

@@ -151,6 +151,7 @@
         "store": "Store",
         "title": "Game Title"
     },
+    "GameSettings": "Game Settings",
     "generic": {
         "error": {
             "component": "No Games found - Try to logout and login again or one of the options bellow"

public/locales/pl/translation.json

@@ -151,6 +151,7 @@
         "store": "Sklep",
         "title": "Tytuł Gry"
     },
+    "GameSettings": "Game Settings",
     "generic": {
         "error": {
             "component": "Nie znaleziono żadnych gier - Spróbuj wylogować i zalogować się ponownie lub postępuj zgodnie z jedną z opcji poniżej"

public/locales/pt/translation.json

@@ -151,6 +151,7 @@
         "store": "Store",
         "title": "Game Title"
     },
+    "GameSettings": "Game Settings",
     "generic": {
         "error": {
             "component": "No Games found - Try to logout and login again or one of the options bellow"

public/locales/pt_BR/translation.json

@@ -151,6 +151,7 @@
         "store": "Loja",
         "title": "Título do jogo"
     },
+    "GameSettings": "Game Settings",
     "generic": {
         "error": {
             "component": "Nenhum jogo encontrado - Tente sair e fazer login novamente ou uma das opções abaixo"

public/locales/ru/translation.json

@@ -151,6 +151,7 @@
         "store": "Магазин",
         "title": "Название игры"
     },
+    "GameSettings": "Game Settings",
     "generic": {
         "error": {
             "component": "Игры не найдены. Попробуйте выйти из системы и войти снова или один из вариантов ниже"

public/locales/sv/translation.json

@@ -151,6 +151,7 @@
         "store": "Store",
         "title": "Game Title"
     },
+    "GameSettings": "Game Settings",
     "generic": {
         "error": {
             "component": "No Games found - Try to logout and login again or one of the options bellow"

public/locales/ta/translation.json

@@ -151,6 +151,7 @@
         "store": "Store",
         "title": "Game Title"
     },
+    "GameSettings": "Game Settings",
     "generic": {
         "error": {
             "component": "No Games found - Try to logout and login again or one of the options bellow"

public/locales/tr/translation.json

@@ -151,6 +151,7 @@
         "store": "Mağaza",
         "title": "Oyun Adı"
     },
+    "GameSettings": "Game Settings",
     "generic": {
         "error": {
             "component": "Oyun bulunamadı - Oturumu kapatıp tekrar açmayı veya aşağıdaki seçeneklerden birini deneyin"

public/locales/uk/translation.json

@@ -151,6 +151,7 @@
         "store": "Магазин",
         "title": "Назва гри"
     },
+    "GameSettings": "Game Settings",
     "generic": {
         "error": {
             "component": "Ігри не знайдено - Спробуйте вийти та увійти наново або один із варіантів нижче"

public/locales/vi/translation.json

@@ -151,6 +151,7 @@
         "store": "Cửa hàng",
         "title": "Tựa game"
     },
+    "GameSettings": "Game Settings",
     "generic": {
         "error": {
             "component": "Không tìm thấy game - Hãy thử đăng xuất rồi đăng nhập lại hoặc một trong các cách sau"

public/locales/zh_Hans/translation.json

@@ -151,6 +151,7 @@
         "store": "商店",
         "title": "游戏名"
     },
+    "GameSettings": "Game Settings",
     "generic": {
         "error": {
             "component": "没有发现游戏 - 尝试注销并再次登录或以下选项之一"

public/locales/zh_Hant/translation.json

@@ -151,6 +151,7 @@
         "store": "商店",
         "title": "遊戲名稱"
     },
+    "GameSettings": "Game Settings",
     "generic": {
         "error": {
             "component": "沒有發現遊戲 - 嘗試登入並再次登入或以下選項之一"

src/components/UI/Sidebar/components/CurrentDownload/index.tsx

@@ -70,7 +70,7 @@ export default function CurrentDownload({ appName, runner }: Props) {
               <Box sx={{ width: '100%', mr: 1 }}>
                 <LinearProgress
                   variant="determinate"
-                  value={progress.percent}
+                  value={progress.percent || 0}
                 />
               </Box>
               <Box sx={{ minWidth: 35 }}>

src/components/UI/Sidebar/components/SidebarLinks/index.tsx

@@ -10,7 +10,7 @@ import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'
 import { NavLink, useNavigate, useLocation } from 'react-router-dom'
 import { openDiscordLink } from 'src/helpers'
 import classNames from 'classnames'
-import React, { useContext } from 'react'
+import React, { useContext, useEffect, useState } from 'react'
 import { useTranslation } from 'react-i18next'
 import { faDiscord, faPatreon } from '@fortawesome/free-brands-svg-icons'
 import {
@@ -46,7 +46,10 @@ export default function SidebarLinks() {
 
   const isStore = location.pathname.includes('store')
   const isSettings = location.pathname.includes('settings')
-  const isDefaultSetting = location.pathname.startsWith('/settings/default')
+  const [isDefaultSetting, setIsDefaultSetting] = useState(
+    location.pathname.startsWith('/settings/default')
+  )
+  const [settingsPath, setSettingsPath] = useState('/settings/default/general')
 
   const {
     hasCloudSave = false,
@@ -62,6 +65,23 @@ export default function SidebarLinks() {
 
   const loggedIn = epic.username || gog.username
 
+  useEffect(() => {
+    let tmpAppName = ''
+    if (location.pathname.startsWith('/gamepage/')) {
+      tmpAppName = location.pathname.replace('/gamepage/', '')
+    } else {
+      tmpAppName = appName !== 'default' ? appName : ''
+    }
+
+    if (tmpAppName) {
+      setSettingsPath(`/settings/${tmpAppName}/wine`)
+      setIsDefaultSetting(false)
+    } else {
+      setSettingsPath('/settings/default/general')
+      setIsDefaultSetting(true)
+    }
+  }, [location])
+
   return (
     <div className="SidebarLinks Sidebar__section">
       {loggedIn && (
@@ -145,14 +165,25 @@ export default function SidebarLinks() {
           className={({ isActive }) =>
             classNames('Sidebar__item', { active: isActive })
           }
-          to={{ pathname: '/settings/default/general' }}
+          to={{ pathname: settingsPath }}
           state={{ fromGameCard: false }}
         >
           <>
             <div className="Sidebar__itemIcon">
-              <FontAwesomeIcon icon={faSlidersH} title={t('Settings')} />
+              <FontAwesomeIcon
+                icon={faSlidersH}
+                title={
+                  isDefaultSetting
+                    ? t('Settings')
+                    : t('GameSettings', 'Game Settings')
+                }
+              />
             </div>
-            <span>{t('Settings')}</span>
+            <span>
+              {isDefaultSetting
+                ? t('Settings')
+                : t('GameSettings', 'Game Settings')}
+            </span>
           </>
         </NavLink>
         {isSettings && (