[Linux/MacOS] Split Enviroment Variable and Wrapper Option

electron/config.ts

@@ -461,7 +461,8 @@ class GlobalConfigV0 extends GlobalConfig {
       maxWorkers: 0,
       minimizeOnLaunch: false,
       nvidiaPrime: false,
-      otherOptions: '',
+      enviromentOptions: [],
+      wrapperOptions: [],
       showUnrealMarket: false,
       showFps: false,
       useGameMode: false,

electron/game_config.ts

@@ -221,7 +221,8 @@ class GameConfigV0 extends GameConfig {
       launcherArgs,
       nvidiaPrime,
       offlineMode,
-      otherOptions,
+      enviromentOptions,
+      wrapperOptions,
       savesPath,
       showFps,
       showMangohud,
@@ -246,7 +247,8 @@ class GameConfigV0 extends GameConfig {
       launcherArgs,
       nvidiaPrime,
       offlineMode,
-      otherOptions,
+      enviromentOptions: enviromentOptions,
+      wrapperOptions,
       savesPath,
       showFps,
       showMangohud,

electron/launcher.ts

@@ -34,8 +34,12 @@ import { DXVK } from './tools'
 import setup from './gog/setup'
 import { GOGGame } from 'gog/games'
 import { LegendaryGame } from 'legendary/games'
-import { CallRunnerOptions, GameInfo, Runner } from './types'
 import {
+  CallRunnerOptions,
+  GameInfo,
+  Runner,
+  EnviromentVariable,
+  WrapperVariable,
   ExecResult,
   GameSettings,
   LaunchPreperationResult,
@@ -240,18 +244,11 @@ function setupEnvVars(gameSettings: GameSettings) {
   if (gameSettings.audioFix) {
     ret.PULSE_LATENCY_MSEC = '60'
   }
-  if (gameSettings.otherOptions) {
-    gameSettings.otherOptions
-      .split(' ')
-      .filter((val) => val.indexOf('=') !== -1)
-      .forEach((envKeyAndVar) => {
-        const keyAndValueSplit = envKeyAndVar.split('=')
-        const key = keyAndValueSplit.shift()
-        const value = keyAndValueSplit.join('=')
-        ret[key] = value
-      })
+  if (gameSettings.enviromentOptions) {
+    gameSettings.enviromentOptions.forEach((envEntry: EnviromentVariable) => {
+      ret[envEntry.key] = quoteIfNecessary(envEntry.value)
+    })
   }
-
   return ret
 }
 
@@ -298,7 +295,9 @@ function setupWineEnvVars(gameSettings: GameSettings, gameId = '0') {
     ret.PROTON_LOG_DIR = flatPakHome
 
     // Only set WINEDEBUG if PROTON_LOG is set since Proton will also log if just WINEDEBUG is set
-    if (gameSettings.otherOptions.includes('PROTON_LOG=')) {
+    if (
+      gameSettings.enviromentOptions.find((env) => env.key === 'PROTON_LOG')
+    ) {
       // Stop Proton from overriding WINEDEBUG; this prevents logs growing to a few GB for some games
       ret.WINEDEBUG = 'timestamp'
     }
@@ -313,14 +312,11 @@ function setupWrappers(
   steamRuntime: string
 ): Array<string> {
   const wrappers = Array<string>()
-  // Wrappers could be specified in the environment variable section as well
-  if (gameSettings.otherOptions) {
-    gameSettings.otherOptions
-      .split(' ')
-      .filter((val) => val.indexOf('=') === -1)
-      .forEach((val) => {
-        wrappers.push(val)
-      })
+  if (gameSettings.wrapperOptions) {
+    gameSettings.wrapperOptions.forEach((wrapperEntry: WrapperVariable) => {
+      wrappers.push(wrapperEntry.exe)
+      wrappers.push(...wrapperEntry.args)
+    })
   }
   if (gameSettings.showMangohud) {
     // Mangohud needs some arguments in addition to the command, so we have to split here

electron/legendary/games.ts

@@ -572,6 +572,7 @@ class LegendaryGame extends Game {
           ...commandEnv,
           ...setupEnvVars(gameSettings)
         }
+
         wrappers = setupWrappers(
           gameSettings,
           mangoHudCommand,
@@ -610,6 +611,7 @@ class LegendaryGame extends Game {
         ...setupEnvVars(gameSettings),
         ...wineEnvVars
       }
+
       wrappers = setupWrappers(
         gameSettings,
         mangoHudCommand,

electron/types.ts

@@ -36,7 +36,8 @@ export interface AppSettings {
   minimizeOnLaunch: boolean
   nvidiaPrime: boolean
   offlineMode: boolean
-  otherOptions: string
+  enviromentOptions: EnviromentVariable[]
+  wrapperOptions: WrapperVariable[]
   savesPath: string
   showFps: boolean
   showMangohud: boolean
@@ -149,7 +150,8 @@ export interface GameSettings {
   launcherArgs: string
   nvidiaPrime: boolean
   offlineMode: boolean
-  otherOptions: string
+  enviromentOptions: EnviromentVariable[]
+  wrapperOptions: WrapperVariable[]
   savesPath: string
   showFps: boolean
   showMangohud: boolean
@@ -374,3 +376,13 @@ export interface CallRunnerOptions {
   wrappers?: string[]
   onOutput?: (output: string) => void
 }
+
+export interface EnviromentVariable {
+  key: string
+  value: string
+}
+
+export interface WrapperVariable {
+  exe: string
+  args: string[]
+}

electron/utils.ts

@@ -543,7 +543,11 @@ const formatEpicStoreUrl = (title: string) => {
 }
 
 function quoteIfNecessary(stringToQuote: string) {
-  if (stringToQuote.includes(' ')) {
+  if (
+    (stringToQuote.charAt(0) !== '"' ||
+      stringToQuote.charAt(stringToQuote.length - 1) !== '"') &&
+    stringToQuote.includes(' ')
+  ) {
     return `"${stringToQuote}"`
   }
   return stringToQuote

public/locales/bg/translation.json

@@ -189,8 +189,7 @@
     },
     "infobox": {
         "help": "Помощ",
-        "requirements": "Системни изисквания",
-        "wine-path": "Path"
+        "requirements": "Системни изисквания"
     },
     "install": {
         "path": "Изберете местоположение за инсталиране"
@@ -244,12 +243,22 @@
     },
     "options": {
         "advanced": {
-            "placeholder": "Тук можете да въведете други аргументи за пускане",
-            "title": "Разширени настройки (променливи на средата):"
+            "key": "Key",
+            "placeHolderKey": "ENVIORMENT",
+            "placeHolderValue": "E.g.: Path/To/ExtraFiles",
+            "title": "Разширени настройки (променливи на средата):",
+            "value": "Value"
         },
         "gameargs": {
             "placeholder": "Въведете аргументите за пускане тук",
             "title": "Аргументи за играта (които да се изпълнят след командата):"
+        },
+        "wrapper": {
+            "args": "Arguments",
+            "exe": "Exe",
+            "placeHolderKey": "Executable Path",
+            "placeHolderValue": "Arguments seperated by semicolon (;) e.g.: --arg; --extra-file=\"file-path/ with/spaces\"",
+            "title": "Wrapper additional arguments"
         }
     },
     "other": {

public/locales/ca/translation.json

@@ -189,8 +189,7 @@
     },
     "infobox": {
         "help": "Ajuda",
-        "requirements": "Requisits del sistema",
-        "wine-path": "Path"
+        "requirements": "Requisits del sistema"
     },
     "install": {
         "path": "Selecciona la ruta d'instal·lació"
@@ -244,12 +243,22 @@
     },
     "options": {
         "advanced": {
-            "placeholder": "Introdueix altres opcions d'inici",
-            "title": "Opcions avançades (variables d'entorn):"
+            "key": "Key",
+            "placeHolderKey": "ENVIORMENT",
+            "placeHolderValue": "E.g.: Path/To/ExtraFiles",
+            "title": "Opcions avançades (variables d'entorn):",
+            "value": "Value"
         },
         "gameargs": {
             "placeholder": "Introdueix aquí els arguments del llançador",
             "title": "Arguments del joc (s'executaran després de l'ordre):"
+        },
+        "wrapper": {
+            "args": "Arguments",
+            "exe": "Exe",
+            "placeHolderKey": "Executable Path",
+            "placeHolderValue": "Arguments seperated by semicolon (;) e.g.: --arg; --extra-file=\"file-path/ with/spaces\"",
+            "title": "Wrapper additional arguments"
         }
     },
     "other": {

public/locales/cs/translation.json

@@ -189,8 +189,7 @@
     },
     "infobox": {
         "help": "Pomoc",
-        "requirements": "Systémové požadavky",
-        "wine-path": "Path"
+        "requirements": "Systémové požadavky"
     },
     "install": {
         "path": "Vyberte cestu instalace"
@@ -244,12 +243,22 @@
     },
     "options": {
         "advanced": {
-            "placeholder": "Sem vložte ostatní možnosti spuštění",
-            "title": "Pokročilé možnosti (Proměnné prostředí):"
+            "key": "Key",
+            "placeHolderKey": "ENVIORMENT",
+            "placeHolderValue": "E.g.: Path/To/ExtraFiles",
+            "title": "Pokročilé možnosti (Proměnné prostředí):",
+            "value": "Value"
         },
         "gameargs": {
             "placeholder": "Sem vložte argumenty spouštěče",
             "title": "Herní argumenty (Pro spuštění po příkazu):"
+        },
+        "wrapper": {
+            "args": "Arguments",
+            "exe": "Exe",
+            "placeHolderKey": "Executable Path",
+            "placeHolderValue": "Arguments seperated by semicolon (;) e.g.: --arg; --extra-file=\"file-path/ with/spaces\"",
+            "title": "Wrapper additional arguments"
         }
     },
     "other": {

public/locales/de/translation.json

@@ -189,8 +189,7 @@
     },
     "infobox": {
         "help": "Hilfe",
-        "requirements": "Systemanforderungen",
-        "wine-path": "Path"
+        "requirements": "Systemanforderungen"
     },
     "install": {
         "path": "Installationspfad auswählen"
@@ -244,12 +243,22 @@
     },
     "options": {
         "advanced": {
-            "placeholder": "Gebe hier andere Startoptionen ein",
-            "title": "Erweiterte Optionen (Umgebungsvariablen):"
+            "key": "Key",
+            "placeHolderKey": "ENVIORMENT",
+            "placeHolderValue": "E.g.: Path/To/ExtraFiles",
+            "title": "Erweiterte Optionen (Umgebungsvariablen):",
+            "value": "Value"
         },
         "gameargs": {
             "placeholder": "Lege hier die Spiel-Argumente fest",
             "title": "Spiel-Argumente (Zur Ausführung nach dem Befehl):"
+        },
+        "wrapper": {
+            "args": "Arguments",
+            "exe": "Exe",
+            "placeHolderKey": "Executable Path",
+            "placeHolderValue": "Arguments seperated by semicolon (;) e.g.: --arg; --extra-file=\"file-path/ with/spaces\"",
+            "title": "Wrapper additional arguments"
         }
     },
     "other": {

public/locales/el/translation.json

@@ -189,8 +189,7 @@
     },
     "infobox": {
         "help": "Βοήθεια",
-        "requirements": "Απαιτήσεις Συστήματος",
-        "wine-path": "Path"
+        "requirements": "Απαιτήσεις Συστήματος"
     },
     "install": {
         "path": "Επιλέξτε διαδρομή εγκατάστασης"
@@ -244,12 +243,22 @@
     },
     "options": {
         "advanced": {
-            "placeholder": "Εισαγάγετε άλλες επιλογές εκκίνησης εδώ",
-            "title": "Προχωρημένες ρυθμίσεις (Μεταβλητές περιβάλλοντος):"
+            "key": "Key",
+            "placeHolderKey": "ENVIORMENT",
+            "placeHolderValue": "E.g.: Path/To/ExtraFiles",
+            "title": "Προχωρημένες ρυθμίσεις (Μεταβλητές περιβάλλοντος):",
+            "value": "Value"
         },
         "gameargs": {
             "placeholder": "Εισαγάγετε τα επιχειρήματα εκκινητή",
             "title": "Επιχειρήματα παιχνιδιού (Εκτέλεση μετά την εντολή):"
+        },
+        "wrapper": {
+            "args": "Arguments",
+            "exe": "Exe",
+            "placeHolderKey": "Executable Path",
+            "placeHolderValue": "Arguments seperated by semicolon (;) e.g.: --arg; --extra-file=\"file-path/ with/spaces\"",
+            "title": "Wrapper additional arguments"
         }
     },
     "other": {

public/locales/en/translation.json

@@ -189,8 +189,7 @@
     },
     "infobox": {
         "help": "Help",
-        "requirements": "System Requirements",
-        "wine-path": "Path"
+        "requirements": "System Requirements"
     },
     "install": {
         "path": "Select Install Path"
@@ -244,12 +243,22 @@
     },
     "options": {
         "advanced": {
-            "placeholder": "Put other launch options here",
-            "title": "Advanced Options (Environment Variables):"
+            "key": "Key",
+            "placeHolderKey": "ENVIORMENT",
+            "placeHolderValue": "E.g.: Path/To/ExtraFiles",
+            "title": "Advanced Options (Environment Variables):",
+            "value": "Value"
         },
         "gameargs": {
             "placeholder": "Put here the Launcher Arguments",
             "title": "Game Arguments (To run after the command):"
+        },
+        "wrapper": {
+            "args": "Arguments",
+            "exe": "Exe",
+            "placeHolderKey": "Executable Path",
+            "placeHolderValue": "Arguments seperated by semicolon (;) e.g.: --arg; --extra-file=\"file-path/ with/spaces\"",
+            "title": "Wrapper additional arguments"
         }
     },
     "other": {