[Linux/MacOS] Split Enviroment Variable and Wrapper Option

[Nocccer]

For better adding of enviroment variables a new component "TwoColTableInput" (Better name requested) was written.

• This component creates a two column table with key and value

• Via Textfields a key and value can be added.

• Via delete button entry can be removed

• Enviroment Variables and Wrapper are now two seperated options.

@arielj Would be very grateful if you could help me with the component. (Design/Improvments)

Launch Command:
Launch Command: MYENV="Hello World" WINEPREFIX=/home/niklas/Games/Heroic/Prefixes/WheelsofAurelia myexe launch --disable-ui /tmp/.mount_HeroicJjlL37/resources/app.asar.unpacked/build/bin/linux/legendary launch Escolar --language de --wine /home/niklas/.config/heroic/tools/wine/Wine-GE-Proton7-16/bin/wine --wine-prefix /home/niklas/Games/Heroic/Prefixes/WheelsofAurelia

---

Use the following Checklist if you have changed something on the Backend or Frontend:

• Tested the feature and it's working on a current and clean install.
• Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
• Created / Updated Tests (If necessary)
• Created / Updated documentation (If necessary)

[imLinguin]

I assume Lutris does something like this

import shlex

arguments_array = shlex.split(arguments_string)

It's literally splitting arguments by spaces omitting those inside of quotes.

[Nocccer]

Ok i will use npm shlex then aswell and i will add a warning.
https://www.npmjs.com/package/shlex

[CommandMC]

It does. Wrote a little thing that prints out argv and added that to Lutris:

sys.argv=['/home/commandmc/src/ArgList/dist/arglist', '--some-arg', '--path', '/path/with/spac es/', '--another-arg']

[Nocccer]

It does. Wrote a little thing that prints out argv and added that to Lutris: sys.argv=['/home/commandmc/src/ArgList/dist/arglist', '--some-arg', '--path', '/path/with/spac es/', '--another-arg']

Ok thanks. I will use shlex because it also removes the quotes. This is pretty good library imo.
There is also shlex.quote(). Maybe we can use this instead quoteIfNecessary()

[CommandMC]

Yup sounds good. Had no idea this library existed to be honest, but it sounds like it's perfect for this

[Nocccer]

@CommandMC ok i rewrote everything like lutris is doing it. Also fixed shlex crashing on undefined strings. Hopefully will be in a future release.
I also fixed launch arguments via shlex.split.
Shlex PR: rgov/node-shlex#22

[flavioislima]

Codewise looks good. Haven't tested yet though but should work fine.
Thanks for refactoring that ⚔️

[Nocccer]

Codewise looks good. Haven't tested yet though but should work fine. Thanks for refactoring that crossed_swords

I added a small fix and a button to edit entries. Can you have another look?

[CommandMC]

With the "Old School Heroic" theme, the table edges are rather hard to make out:

Also, the "Variable Name"/"Value"/"Wrapper" text feels a little out of place IMO. Does it really have to be a different font size than all other text on the site? Why not use <h3> like the settings sub-heading does?

[Nocccer]

With the "Old School Heroic" theme, the table edges are rather hard to make out:

Also, the "Variable Name"/"Value"/"Wrapper" text feels a little out of place IMO. Does it really have to be a different font size than all other text on the site? Why not use <h3> like the settings sub-heading does?

Before i mess something up in CSS, maybe @arielj can fix this?

[arielj]

With the "Old School Heroic" theme, the table edges are rather hard to make out:
Also, the "Variable Name"/"Value"/"Wrapper" text feels a little out of place IMO. Does it really have to be a different font size than all other text on the site? Why not use <h3> like the settings sub-heading does?

Before i mess something up in CSS, maybe @arielj can fix this?

I'll check!

[arielj]

I added the fix in this PR since it was pretty simple, but the theme in general had a problem with the inputs having the same background as the background, I changed that so now it has better contrast and it looks better and more like the other themes

[GenocideStomper]

How does this wrapper functionality work? Comparing to Lutris, is it supposed to work like the "Pre-launch script" functionality, or "Command prefix"? Or perhaps something completely different?

Basically I want to run kde-inhibit --colorCorrect as long as the game is running, sort of like mangohud or gamemoderun would be if manually executed.
However when I set kde-inhibit --colorCorrect as a wrapper, it executes briefly and exits before the game starts.