Skip to content

No longer log commands twice #1405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

CommandMC
Copy link
Collaborator

@CommandMC CommandMC commented May 29, 2022

  • getLegendaryOrGogdlCommand and its variants are no longer exposed/no longer exist
  • A new purpose attribute was added to runLegendaryOrGogdlCommand's options, which makes it possible to define what the command we're running is supposed to do
  • Instances of the "getCommand, log it with custom message, runCommand" workflow have been converted to using purpose

I think this is a good compromise between being verbose on what we're doing vs avoiding log spam


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC requested review from Nocccer and flavioislima May 29, 2022 14:20
@Nocccer
Copy link
Collaborator

Nocccer commented May 29, 2022

I don't know if we need the purpose attribute. I will see tomorrow how i would implement it. Maybe i miss something and we need the purpose, but i want todo it with less arguments

@CommandMC
Copy link
Collaborator Author

Superseded by #1415

@CommandMC CommandMC closed this May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants