Skip to content

[General] Restructure/Cleanup of runLegendaryOrGogdlCommand #1415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2022

Conversation

Nocccer
Copy link
Collaborator

@Nocccer Nocccer commented May 30, 2022

  • renamed runLegendaryOrGogdlCommand to callRunner
  • renamed getLegendaryOrGogdlCommand to getRunnerCallWithoutCredentials
  • Removed unessecary functions and logs
    • removed getLegendaryCommand and getGogdlCommand
  • Used type Runner for runner.name to avoid type conflict
  • Cleanup code

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

- removed unessecary functions and logs
- cleanup unessecary code
@Nocccer Nocccer requested review from CommandMC and flavioislima May 30, 2022 14:35
@Nocccer Nocccer changed the title [General] Restructure/Cleanup of runLegendaryOrGogCommand [General] Restructure/Cleanup of runLegendaryOrGogdlCommand May 30, 2022
Copy link
Collaborator

@CommandMC CommandMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this feels like you're just changing things to make this different from my PR.
The old implementation wasn't perfect, but this doesn't make it better.

@Nocccer
Copy link
Collaborator Author

Nocccer commented May 31, 2022

I resolved everything for now. Feel free to reopen stuff.

@CommandMC CommandMC mentioned this pull request May 31, 2022
4 tasks
@flavioislima flavioislima changed the base branch from main to beta May 31, 2022 15:47
@Nocccer Nocccer merged commit 8e517e9 into beta Jun 1, 2022
@Nocccer Nocccer deleted the refactor_runCommand branch June 1, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants