Skip to content

Allow specifying wrappers in the env var section again #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 24, 2022

Conversation

CommandMC
Copy link
Collaborator

@CommandMC CommandMC commented May 22, 2022

With this patch, you can now enter wrappers into the environment variable section of the game settings again & they will be properly executed instead of being added as empty variables


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC added pr:ready-for-review Feature-complete, ready for the grind! :P and removed pr:testing This PR is in testing, don't merge. labels May 23, 2022
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but can you check with gamescope or other tools?

@CommandMC
Copy link
Collaborator Author

I've tested it with gamescope now & just by adding echo before, works fine. People on the issue are also reporting that it's working. So I guess I'll merge?

@flavioislima
Copy link
Member

Yes, ready to merge! :D

@flavioislima flavioislima added pr:ready-to-merge This PR is fully ready for merge. and removed pr:ready-for-review Feature-complete, ready for the grind! :P labels May 24, 2022
@CommandMC CommandMC merged commit 713faaf into Heroic-Games-Launcher:main May 24, 2022
@CommandMC CommandMC deleted the allow-env-wrappers branch May 24, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-to-merge This PR is fully ready for merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants