Skip to content

fix: Failing tests on CI #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 3, 2024
Merged

fix: Failing tests on CI #641

merged 4 commits into from
May 3, 2024

Conversation

tuliomir
Copy link
Contributor

@tuliomir tuliomir commented May 1, 2024

This PR aims to fix minor bugs on the CI tests before upgrading to NodeJS 20 on #635 :

After upgrading to NodeJS 20, the mineTransaction.test.ts unit tests started failing. This was due to a stricter policy by Node of crashing whenever there is an unhandled promise in the application, instead of just emitting a warning as it was on NodeJS 14.

Acceptance Criteria

  • Promises on MineTransaction tests should always be handled
  • The CI must be passing for all PRs

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir added the bug Something isn't working label May 1, 2024
@tuliomir tuliomir self-assigned this May 1, 2024
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.48%. Comparing base (2169306) to head (32e43e3).

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #641       +/-   ##
===========================================
+ Coverage   62.01%   79.48%   +17.47%     
===========================================
  Files          77       77               
  Lines        5826     5826               
  Branches     1223     1210       -13     
===========================================
+ Hits         3613     4631     +1018     
+ Misses       2116     1178      -938     
+ Partials       97       17       -80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tuliomir tuliomir marked this pull request as ready for review May 1, 2024 14:50
@tuliomir tuliomir requested a review from pedroferreira1 as a code owner May 1, 2024 14:50
@tuliomir tuliomir changed the title fix: submitJob test fix: Failing tests on CI May 2, 2024
@tuliomir tuliomir requested a review from alexruzenhack May 2, 2024 12:02
alexruzenhack
alexruzenhack previously approved these changes May 2, 2024
@tuliomir tuliomir requested a review from alexruzenhack May 3, 2024 13:36
@tuliomir tuliomir merged commit 394c2ca into master May 3, 2024
6 checks passed
@tuliomir tuliomir deleted the fix/submitjob branch May 3, 2024 13:39
This was referenced May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants