-
Notifications
You must be signed in to change notification settings - Fork 15
fix: Failing tests on CI #641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #641 +/- ##
===========================================
+ Coverage 62.01% 79.48% +17.47%
===========================================
Files 77 77
Lines 5826 5826
Branches 1223 1210 -13
===========================================
+ Hits 3613 4631 +1018
+ Misses 2116 1178 -938
+ Partials 97 17 -80 ☔ View full report in Codecov by Sentry. |
tuliomir
commented
May 2, 2024
tuliomir
commented
May 2, 2024
alexruzenhack
previously approved these changes
May 2, 2024
pedroferreira1
approved these changes
May 2, 2024
alexruzenhack
approved these changes
May 3, 2024
This was referenced May 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix minor bugs on the CI tests before upgrading to NodeJS 20 on #635 :
After upgrading to NodeJS 20, the
mineTransaction.test.ts
unit tests started failing. This was due to a stricter policy by Node of crashing whenever there is an unhandled promise in the application, instead of just emitting a warning as it was on NodeJS 14.Acceptance Criteria
MineTransaction
tests should always be handledSecurity Checklist