Skip to content

chore: Upgrades NodeJS to 20 #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2024
Merged

chore: Upgrades NodeJS to 20 #635

merged 1 commit into from
May 4, 2024

Conversation

tuliomir
Copy link
Contributor

@tuliomir tuliomir commented Apr 10, 2024

Acceptance Criteria

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir added the dependencies Pull requests that update a dependency file label Apr 10, 2024
@tuliomir tuliomir self-assigned this Apr 10, 2024
@tuliomir tuliomir force-pushed the chore/upgrades-nodejs branch from 4478d30 to 17068ee Compare May 1, 2024 12:46
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.48%. Comparing base (394c2ca) to head (b5bc37b).

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #635       +/-   ##
===========================================
+ Coverage   62.01%   79.48%   +17.47%     
===========================================
  Files          77       77               
  Lines        5826     5826               
  Branches     1210     1223       +13     
===========================================
+ Hits         3613     4631     +1018     
+ Misses       2116     1178      -938     
+ Partials       97       17       -80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tuliomir tuliomir marked this pull request as ready for review May 1, 2024 14:41
@tuliomir tuliomir requested a review from pedroferreira1 as a code owner May 1, 2024 14:41
@tuliomir tuliomir mentioned this pull request May 2, 2024
1 task
@tuliomir tuliomir force-pushed the chore/upgrades-nodejs branch from 083d16b to 617a887 Compare May 2, 2024 12:10
@tuliomir tuliomir changed the base branch from master to fix/submitjob May 2, 2024 12:11
@tuliomir tuliomir requested a review from alexruzenhack May 2, 2024 12:11
Base automatically changed from fix/submitjob to master May 3, 2024 13:39
@tuliomir tuliomir force-pushed the chore/upgrades-nodejs branch from 617a887 to b5bc37b Compare May 3, 2024 13:41
@tuliomir tuliomir merged commit be393cb into master May 4, 2024
4 checks passed
@tuliomir tuliomir deleted the chore/upgrades-nodejs branch May 4, 2024 00:00
This was referenced May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants