Skip to content

chore(custom_checks): Skip binary files when checking for deprecated typing #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

msbrogli
Copy link
Member

@msbrogli msbrogli commented Nov 3, 2023

Motivation

If a file is open in vim, this skip wrongfully fails because the .swp file concatenate lines using a custom separator so the whole file is considered as in one line.

Acceptance Criteria

  1. Use grep -I option to skip binary files.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@msbrogli msbrogli requested a review from jansegre as a code owner November 3, 2023 00:59
@msbrogli msbrogli self-assigned this Nov 3, 2023
@msbrogli msbrogli requested a review from glevco November 3, 2023 00:59
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c47f06e) 85.01% compared to head (50a18a9) 85.01%.

❗ Current head 50a18a9 differs from pull request most recent head b0642e2. Consider uploading reports for the commit b0642e2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #846   +/-   ##
=======================================
  Coverage   85.01%   85.01%           
=======================================
  Files         271      271           
  Lines       22368    22362    -6     
  Branches     3420     3416    -4     
=======================================
- Hits        19017    19012    -5     
+ Misses       2675     2674    -1     
  Partials      676      676           

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jansegre jansegre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I set up vim to store temp files in a dedicated dir, so I never experienced this.

@msbrogli msbrogli force-pushed the chore/fix-custom-checks-binary-files branch from 50a18a9 to b0642e2 Compare November 3, 2023 15:47
@msbrogli msbrogli merged commit b0642e2 into master Nov 3, 2023
@msbrogli msbrogli deleted the chore/fix-custom-checks-binary-files branch November 3, 2023 15:48
@jansegre jansegre mentioned this pull request Nov 13, 2023
2 tasks
This was referenced Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants