chore(custom_checks): Skip binary files when checking for deprecated typing

msbrogli · msbrogli · commit 50a18a95cfc6 · 2023-11-02T19:57:27.000-05:00
diff --git a/extras/custom_checks.sh b/extras/custom_checks.sh
@@ -72,7 +72,7 @@ function check_do_not_use_builtin_random_in_tests() {
 }
 
 function check_deprecated_typing() {
-	if grep -R '\<typing .*\<import .*\<\(Tuple\|List\|Dict\|Set\|FrozenSet\|AbstractSet\|DefaultDict\|OrderedDict\)\>' "${SOURCE_DIRS[@]}"; then
+	if grep -RI '\<typing .*\<import .*\<\(Tuple\|List\|Dict\|Set\|FrozenSet\|AbstractSet\|DefaultDict\|OrderedDict\)\>' "${SOURCE_DIRS[@]}"; then
 		echo 'do not use typing.List/Tuple/Dict/... for type annotations use builtin list/tuple/dict/... instead'
 		echo 'for more info check the PEP 585 doc: https://peps.python.org/pep-0585/'
 		return 1

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ function check_do_not_use_builtin_random_in_tests() {`
`72`	`72`	`}`
`73`	`73`
`74`	`74`	`function check_deprecated_typing() {`
`75`		`- if grep -R '\<typing .\<import .\<\(Tuple\\|List\\|Dict\\|Set\\|FrozenSet\\|AbstractSet\\|DefaultDict\\|OrderedDict\)\>' "${SOURCE_DIRS[@]}"; then`
	`75`	`+ if grep -RI '\<typing .\<import .\<\(Tuple\\|List\\|Dict\\|Set\\|FrozenSet\\|AbstractSet\\|DefaultDict\\|OrderedDict\)\>' "${SOURCE_DIRS[@]}"; then`
`76`	`76`	`echo 'do not use typing.List/Tuple/Dict/... for type annotations use builtin list/tuple/dict/... instead'`
`77`	`77`	`echo 'for more info check the PEP 585 doc: https://peps.python.org/pep-0585/'`
`78`	`78`	`return 1`