-
Notifications
You must be signed in to change notification settings - Fork 29
refactor(verification): remove VertexVerifier inheritance [part 6/9] #835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
glevco
merged 1 commit into
master
from
refactor/verification-inheritance/6-remove-vertex-inheritance
Dec 4, 2023
Merged
refactor(verification): remove VertexVerifier inheritance [part 6/9] #835
glevco
merged 1 commit into
master
from
refactor/verification-inheritance/6-remove-vertex-inheritance
Dec 4, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #835 +/- ##
==========================================
- Coverage 85.31% 85.27% -0.04%
==========================================
Files 282 283 +1
Lines 22419 22421 +2
Branches 3402 3400 -2
==========================================
- Hits 19126 19119 -7
- Misses 2609 2612 +3
- Partials 684 690 +6 ☔ View full report in Codecov by Sentry. |
ab0ada3
to
8a2ce37
Compare
f1553f4
to
738e2cb
Compare
8a2ce37
to
eedb7b7
Compare
738e2cb
to
367093e
Compare
eedb7b7
to
beae626
Compare
367093e
to
0dec101
Compare
beae626
to
76914ee
Compare
0dec101
to
b076a15
Compare
76914ee
to
11ad5b6
Compare
b076a15
to
da25588
Compare
4e2d986
to
bad9939
Compare
da25588
to
6e3e325
Compare
Base automatically changed from
refactor/verification-inheritance/5-remove-tx-inheritance
to
master
November 29, 2023 03:07
6e3e325
to
36aa21f
Compare
msbrogli
approved these changes
Nov 30, 2023
jansegre
approved these changes
Dec 1, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #834
Motivation
Simplify verification by removing the
VertexVerifier
inheritance fromBlockVerifier
, andTransactionVerifier
, as it was not necessary. It's changed to composition instead, but this will also be removed in next PRs.This allows us to simplify more code downstream, and will culminate in streamlining the whole verification process without using inheritance.
Read #833 for more info.
Acceptance Criteria
verify_outputs()
in bothBlockVerifier
andTransactionVerifier
to useVertexVerifier
composition instead of inheritance.VertexVerifiers
to its own file, implementing newcreate()
method.SimulatorVertexVerifier
.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged