Skip to content

refactor(verification): remove VertexVerifier inheritance [part 6/9] #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Oct 27, 2023

Depends on #834

Motivation

Simplify verification by removing the VertexVerifier inheritance from BlockVerifier, and TransactionVerifier, as it was not necessary. It's changed to composition instead, but this will also be removed in next PRs.

This allows us to simplify more code downstream, and will culminate in streamlining the whole verification process without using inheritance.

Read #833 for more info.

Acceptance Criteria

  • Change verify_outputs() in both BlockVerifier and TransactionVerifier to use VertexVerifier composition instead of inheritance.
  • Move VertexVerifiers to its own file, implementing new create() method.
  • Remove all custom Simulator verifiers, leaving only a custom SimulatorVertexVerifier.
  • Update usages accordingly.
  • No behavior should be changed by this PR.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Oct 27, 2023
@glevco glevco changed the title refactor(verification): remove VertexVerifier inheritance refactor(verification): remove VertexVerifier inheritance [part 6/9] Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (11a84eb) 85.31% compared to head (36aa21f) 85.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #835      +/-   ##
==========================================
- Coverage   85.31%   85.27%   -0.04%     
==========================================
  Files         282      283       +1     
  Lines       22419    22421       +2     
  Branches     3402     3400       -2     
==========================================
- Hits        19126    19119       -7     
- Misses       2609     2612       +3     
- Partials      684      690       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco force-pushed the refactor/verification-inheritance/5-remove-tx-inheritance branch 2 times, most recently from ab0ada3 to 8a2ce37 Compare November 10, 2023 17:10
@glevco glevco force-pushed the refactor/verification-inheritance/6-remove-vertex-inheritance branch 2 times, most recently from f1553f4 to 738e2cb Compare November 10, 2023 19:07
@glevco glevco marked this pull request as ready for review November 10, 2023 20:04
@glevco glevco force-pushed the refactor/verification-inheritance/5-remove-tx-inheritance branch from 8a2ce37 to eedb7b7 Compare November 16, 2023 17:04
@glevco glevco force-pushed the refactor/verification-inheritance/6-remove-vertex-inheritance branch from 738e2cb to 367093e Compare November 16, 2023 17:04
@glevco glevco force-pushed the refactor/verification-inheritance/5-remove-tx-inheritance branch from eedb7b7 to beae626 Compare November 16, 2023 20:05
@glevco glevco force-pushed the refactor/verification-inheritance/6-remove-vertex-inheritance branch from 367093e to 0dec101 Compare November 16, 2023 20:05
@glevco glevco force-pushed the refactor/verification-inheritance/5-remove-tx-inheritance branch from beae626 to 76914ee Compare November 16, 2023 21:24
@glevco glevco force-pushed the refactor/verification-inheritance/6-remove-vertex-inheritance branch from 0dec101 to b076a15 Compare November 16, 2023 21:25
@glevco glevco force-pushed the refactor/verification-inheritance/5-remove-tx-inheritance branch from 76914ee to 11ad5b6 Compare November 27, 2023 20:22
@glevco glevco force-pushed the refactor/verification-inheritance/6-remove-vertex-inheritance branch from b076a15 to da25588 Compare November 27, 2023 20:23
@glevco glevco force-pushed the refactor/verification-inheritance/5-remove-tx-inheritance branch 2 times, most recently from 4e2d986 to bad9939 Compare November 29, 2023 02:14
@glevco glevco force-pushed the refactor/verification-inheritance/6-remove-vertex-inheritance branch from da25588 to 6e3e325 Compare November 29, 2023 02:14
Base automatically changed from refactor/verification-inheritance/5-remove-tx-inheritance to master November 29, 2023 03:07
@glevco glevco force-pushed the refactor/verification-inheritance/6-remove-vertex-inheritance branch from 6e3e325 to 36aa21f Compare November 29, 2023 03:08
@glevco glevco merged commit a575945 into master Dec 4, 2023
@glevco glevco deleted the refactor/verification-inheritance/6-remove-vertex-inheritance branch December 4, 2023 18:57
@jansegre jansegre mentioned this pull request Dec 11, 2023
2 tasks
This was referenced Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants