Skip to content

refactor(verification): remove TransactionVerifier inheritance [part 5/9] #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Oct 27, 2023

Depends on #833

Motivation

Simplify transaction verification by removing the TransactionVerifier inheritance from TokenCreationTransactionVerifier, as it was not necessary. It's changed to composition instead, but this is also going to be removed in a next PR.

For more info, read the previous PR (#833).

Acceptance Criteria

  • Move verify_basic(), verify(), and verify_without_storage() from TransactionVerifier to VerificationService.
  • Move verify() from TokenCreationTransactionVerifier to VerificationService, removing its TransactionVerifier inheritance, and changing it to composition instead.
  • Update usages accordingly.
  • No behavior should be changed by this PR.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Oct 27, 2023
@glevco glevco changed the title refactor(verification): remove TransactionVerifier inheritance refactor(verification): remove TransactionVerifier inheritance [part 5/9] Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (573c054) 85.24% compared to head (bad9939) 85.32%.

Files Patch % Lines
hathor/verification/verification_service.py 94.44% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #834      +/-   ##
==========================================
+ Coverage   85.24%   85.32%   +0.07%     
==========================================
  Files         282      282              
  Lines       22413    22419       +6     
  Branches     3402     3402              
==========================================
+ Hits        19107    19129      +22     
+ Misses       2615     2606       -9     
+ Partials      691      684       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco force-pushed the refactor/verification-inheritance/4-remove-block-inheritance branch from afef179 to f7652cb Compare November 10, 2023 16:32
@glevco glevco force-pushed the refactor/verification-inheritance/5-remove-tx-inheritance branch from 335b7a0 to ab0ada3 Compare November 10, 2023 16:52
@glevco glevco force-pushed the refactor/verification-inheritance/4-remove-block-inheritance branch from f7652cb to 0242b97 Compare November 10, 2023 17:04
@glevco glevco force-pushed the refactor/verification-inheritance/5-remove-tx-inheritance branch from ab0ada3 to 8a2ce37 Compare November 10, 2023 17:10
@glevco glevco marked this pull request as ready for review November 10, 2023 20:00
@glevco glevco force-pushed the refactor/verification-inheritance/4-remove-block-inheritance branch from 0242b97 to a9205ca Compare November 16, 2023 17:04
@glevco glevco force-pushed the refactor/verification-inheritance/5-remove-tx-inheritance branch from 8a2ce37 to eedb7b7 Compare November 16, 2023 17:04
@glevco glevco force-pushed the refactor/verification-inheritance/4-remove-block-inheritance branch from a9205ca to 7be536d Compare November 16, 2023 20:05
@glevco glevco force-pushed the refactor/verification-inheritance/5-remove-tx-inheritance branch from eedb7b7 to beae626 Compare November 16, 2023 20:05
@glevco glevco force-pushed the refactor/verification-inheritance/4-remove-block-inheritance branch from 7be536d to 7fbb16a Compare November 16, 2023 21:24
@glevco glevco force-pushed the refactor/verification-inheritance/5-remove-tx-inheritance branch from beae626 to 76914ee Compare November 16, 2023 21:24
@glevco glevco force-pushed the refactor/verification-inheritance/4-remove-block-inheritance branch 4 times, most recently from 64c94b8 to 2d102bb Compare November 24, 2023 16:06
Base automatically changed from refactor/verification-inheritance/4-remove-block-inheritance to master November 24, 2023 17:12
@glevco glevco force-pushed the refactor/verification-inheritance/5-remove-tx-inheritance branch from 76914ee to 11ad5b6 Compare November 27, 2023 20:22
@glevco glevco force-pushed the refactor/verification-inheritance/5-remove-tx-inheritance branch from 11ad5b6 to 4e2d986 Compare November 28, 2023 21:40
@glevco glevco force-pushed the refactor/verification-inheritance/5-remove-tx-inheritance branch from 4e2d986 to bad9939 Compare November 29, 2023 02:14
@glevco glevco merged commit 11a84eb into master Nov 29, 2023
@glevco glevco deleted the refactor/verification-inheritance/5-remove-tx-inheritance branch November 29, 2023 03:07
@jansegre jansegre mentioned this pull request Dec 11, 2023
2 tasks
This was referenced Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants