-
Notifications
You must be signed in to change notification settings - Fork 29
refactor(verification): remove TransactionVerifier inheritance [part 5/9] #834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
glevco
merged 1 commit into
master
from
refactor/verification-inheritance/5-remove-tx-inheritance
Nov 29, 2023
Merged
refactor(verification): remove TransactionVerifier inheritance [part 5/9] #834
glevco
merged 1 commit into
master
from
refactor/verification-inheritance/5-remove-tx-inheritance
Nov 29, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #834 +/- ##
==========================================
+ Coverage 85.24% 85.32% +0.07%
==========================================
Files 282 282
Lines 22413 22419 +6
Branches 3402 3402
==========================================
+ Hits 19107 19129 +22
+ Misses 2615 2606 -9
+ Partials 691 684 -7 ☔ View full report in Codecov by Sentry. |
afef179
to
f7652cb
Compare
335b7a0
to
ab0ada3
Compare
f7652cb
to
0242b97
Compare
ab0ada3
to
8a2ce37
Compare
0242b97
to
a9205ca
Compare
8a2ce37
to
eedb7b7
Compare
a9205ca
to
7be536d
Compare
eedb7b7
to
beae626
Compare
7be536d
to
7fbb16a
Compare
beae626
to
76914ee
Compare
64c94b8
to
2d102bb
Compare
Base automatically changed from
refactor/verification-inheritance/4-remove-block-inheritance
to
master
November 24, 2023 17:12
76914ee
to
11ad5b6
Compare
msbrogli
approved these changes
Nov 28, 2023
jansegre
approved these changes
Nov 28, 2023
11ad5b6
to
4e2d986
Compare
4e2d986
to
bad9939
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #833
Motivation
Simplify transaction verification by removing the
TransactionVerifier
inheritance fromTokenCreationTransactionVerifier
, as it was not necessary. It's changed to composition instead, but this is also going to be removed in a next PR.For more info, read the previous PR (#833).
Acceptance Criteria
verify_basic()
,verify()
, andverify_without_storage()
fromTransactionVerifier
toVerificationService
.verify()
fromTokenCreationTransactionVerifier
toVerificationService
, removing itsTransactionVerifier
inheritance, and changing it to composition instead.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged