refactor: cleanup full verification #1218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevco
force-pushed
the
refactor/cleanup-full-verification
branch
from
31eb47b to
7ca1e19
Compare
|
Bencher Report| Branch | refactor/cleanup-full-verification |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.54(-5.45%)Baseline: 1.63 | 1.47 (95.19%) | 1.79 (85.95%) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1218 +/- ##
==========================================
- Coverage 84.50% 84.30% -0.21%
==========================================
Files 320 320
Lines 24584 24455 -129
Branches 3767 3744 -23
==========================================
- Hits 20774 20616 -158
- Misses 3075 3106 +31
+ Partials 735 733 -2 ☔ View full report in Codecov by Sentry. |
glevco
commented
Feb 4, 2025
1 task
jansegre
previously approved these changes
Feb 5, 2025
msbrogli
previously approved these changes
Feb 11, 2025
glevco
force-pushed
the
refactor/cleanup-full-verification
branch
from
7ca1e19 to
40650fb
Compare
glevco
force-pushed
the
refactor/cleanup-full-verification
branch
from
40650fb to
57a9c4c
Compare
glevco
force-pushed
the
refactor/cleanup-full-verification
branch
from
4213660 to
2b31858
Compare
jansegre
approved these changes
Feb 18, 2025
msbrogli
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Recent PR #1206 deprecated
--x-full-verification, but its code was not cleaned up. This PR does this.Acceptance Criteria
HathorManager._initialize_components_new()to_initialize_components().Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged