Skip to content

refactor(misc): minor maintenance changes #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Jan 29, 2025

Motivation

This PR accumulates some minor cleanups, see below.

Acceptance Criteria

  • Update event queue docs to remove mention of unsafe — that feature is no longer unsafe, but the docs were outdated.
  • Handle unhandled exception in the deferred returned by handle_peer_id() — this currently generates unnecessary alerts.
  • Remove HAS_ROCKSDB variable and all its usage — since we removed support for windows, this is not necessary anymore.
  • Deprecate --x-full-verification.
  • Refactor execution manager call.
  • No changes in behavior.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Jan 29, 2025
@glevco glevco marked this pull request as ready for review January 29, 2025 18:20
Copy link

github-actions bot commented Jan 29, 2025

🐰 Bencher Report

Branchrefactor/misc-changes
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.52
(-7.31%)
1.47
(97.10%)
1.80
(84.26%)
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 94.28571% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.41%. Comparing base (2c6efb3) to head (ef73420).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
hathor/p2p/states/peer_id.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1206      +/-   ##
==========================================
- Coverage   84.54%   84.41%   -0.14%     
==========================================
  Files         320      320              
  Lines       24562    24568       +6     
  Branches     3767     3768       +1     
==========================================
- Hits        20766    20739      -27     
- Misses       3061     3085      +24     
- Partials      735      744       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco force-pushed the refactor/misc-changes branch from 30fc72e to 173d8c1 Compare January 31, 2025 03:33
msbrogli
msbrogli previously approved these changes Feb 3, 2025
@glevco glevco force-pushed the refactor/misc-changes branch from 173d8c1 to d183cb9 Compare February 3, 2025 19:27
jansegre
jansegre previously approved these changes Feb 3, 2025
@glevco glevco dismissed stale reviews from jansegre and msbrogli via d1ebf44 February 3, 2025 20:41
@glevco glevco force-pushed the refactor/misc-changes branch from d183cb9 to d1ebf44 Compare February 3, 2025 20:41
msbrogli
msbrogli previously approved these changes Feb 3, 2025
jansegre
jansegre previously approved these changes Feb 3, 2025
@jansegre jansegre mentioned this pull request Feb 3, 2025
2 tasks
@glevco glevco dismissed stale reviews from jansegre and msbrogli via afe821b February 3, 2025 20:53
@glevco glevco force-pushed the refactor/misc-changes branch from d1ebf44 to afe821b Compare February 3, 2025 20:53
@glevco glevco force-pushed the refactor/misc-changes branch from afe821b to ef73420 Compare February 3, 2025 21:21
@msbrogli msbrogli merged commit ef73420 into master Feb 3, 2025
8 of 9 checks passed
@msbrogli msbrogli deleted the refactor/misc-changes branch February 3, 2025 21:27
@jansegre jansegre mentioned this pull request Feb 4, 2025
2 tasks
@glevco glevco mentioned this pull request Feb 4, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting to be deployed
Development

Successfully merging this pull request may close these issues.

3 participants