-
Notifications
You must be signed in to change notification settings - Fork 29
refactor(misc): minor maintenance changes #1206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Branch | refactor/misc-changes |
Testbed | ubuntu-22.04 |
Click to view all benchmark results
Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
---|---|---|---|---|
sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.52 (-7.31%) | 1.47 (97.10%) | 1.80 (84.26%) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1206 +/- ##
==========================================
- Coverage 84.54% 84.41% -0.14%
==========================================
Files 320 320
Lines 24562 24568 +6
Branches 3767 3768 +1
==========================================
- Hits 20766 20739 -27
- Misses 3061 3085 +24
- Partials 735 744 +9 ☔ View full report in Codecov by Sentry. |
30fc72e
to
173d8c1
Compare
msbrogli
previously approved these changes
Feb 3, 2025
173d8c1
to
d183cb9
Compare
jansegre
previously approved these changes
Feb 3, 2025
d183cb9
to
d1ebf44
Compare
msbrogli
previously approved these changes
Feb 3, 2025
jansegre
previously approved these changes
Feb 3, 2025
2 tasks
d1ebf44
to
afe821b
Compare
afe821b
to
ef73420
Compare
msbrogli
approved these changes
Feb 3, 2025
jansegre
approved these changes
Feb 3, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR accumulates some minor cleanups, see below.
Acceptance Criteria
handle_peer_id()
— this currently generates unnecessary alerts.HAS_ROCKSDB
variable and all its usage — since we removed support for windows, this is not necessary anymore.--x-full-verification
.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged