chore: remove the limited support there was for Windows #1169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansegre
force-pushed
the
chore/remove-windows-support
branch
2 times, most recently
from
b77a0db to
c707573
Compare
glevco
previously approved these changes
Oct 25, 2024
msbrogli
previously approved these changes
Oct 25, 2024
|
Bencher Report| Branch | chore/remove-windows-support |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Lower Boundary nanoseconds (ns) (Limit %) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 101,474,550,995.10 (-0.33%) | 91,630,819,608.93 (90.30%) | 111,993,223,966.47 (90.61%) |
jansegre
force-pushed
the
chore/remove-windows-support
branch
from
c707573 to
da9924c
Compare
glevco
approved these changes
Oct 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1169 +/- ##
==========================================
- Coverage 84.70% 84.64% -0.07%
==========================================
Files 313 313
Lines 24249 24246 -3
Branches 3690 3689 -1
==========================================
- Hits 20541 20522 -19
- Misses 2997 3007 +10
- Partials 711 717 +6 ☔ View full report in Codecov by Sentry. |
jansegre
force-pushed
the
chore/remove-windows-support
branch
from
da9924c to
4200cc2
Compare
msbrogli
approved these changes
Oct 31, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Windows support has been very bare, undertested and there are no use cases that could not run on WSL instead.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged