chore: remove the limited support there was for Windows

Author: jansegre

.github/workflows/main.yml

@@ -25,7 +25,7 @@ jobs:
           full_matrix = {
             'python': ['3.10', '3.11', '3.12'],
             # available OS's: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idruns-on
-            'os': ['ubuntu-22.04', 'macos-12', 'windows-2022'],
+            'os': ['ubuntu-22.04', 'macos-12'],
           }
           # this is the fastest one:
           reduced_matrix = {

poetry.lock

@@ -64,13 +64,12 @@ mnemonic = "~0.20"
 prometheus_client = "~0.15.0"
 pyopenssl = "=24.2.1"
 pycoin = "~0.92.20230326"
-pywin32 = {version = "306", markers = "sys_platform == 'win32'"}
 requests = "=2.32.3"
 service_identity = "~21.1.0"
 pexpect = "~4.8.0"
 intervaltree = "~3.1.0"
 structlog = "~22.3.0"
-rocksdb = {git = "https://github.com/hathornetwork/python-rocksdb.git", markers = "sys_platform != 'win32'"}
+rocksdb = {git = "https://github.com/hathornetwork/python-rocksdb.git"}
 aiohttp = "~3.10.3"
 idna = "~3.4"
 setproctitle = "^1.3.3"

pyproject.toml

@@ -6,9 +6,5 @@
 
 os.environ['HATHOR_CONFIG_YAML'] = os.environ.get('HATHOR_TEST_CONFIG_YAML', UNITTESTS_SETTINGS_FILEPATH)
 
-if sys.platform == 'win32':
-    # XXX: because rocksdb isn't available on Windows, we force using memory-storage for tests so most of them can run
-    os.environ['HATHOR_TEST_MEMORY_STORAGE'] = 'true'
-
 # TODO: We should remove this call from the module level.
 initialize_global_reactor(use_asyncio_reactor=True)

tests/conftest.py

@@ -8,7 +8,6 @@
 
 
 class ConnectionsTest(unittest.TestCase):
-    @pytest.mark.skipif(sys.platform == 'win32', reason='run_server is very finicky on Windows')
     def test_connections(self) -> None:
         process = run_server()
         process2 = run_server(listen=8006, status=8086, bootstrap='tcp://127.0.0.1:8005')

tests/p2p/test_connections.py

@@ -19,7 +19,6 @@ def setUp(self):
         super().setUp()
         self.web = StubSite(ProfilerResource(self.manager))
 
-    @pytest.mark.skipif(sys.platform == 'win32', reason='shutil.rmtree fails on Windows')
     @inlineCallbacks
     def test_post(self):
         # Options

tests/resources/test_profiler.py

@@ -20,7 +20,6 @@ def setUp(self):
         self.network = 'testnet'
         self.manager = self.create_peer(self.network, unlock_wallet=True)
 
-    @pytest.mark.skipif(sys.platform == 'win32', reason='set_new_metrics fails on Windows')
     def test_wallet(self):
         tmpdir = tempfile.mkdtemp()
         tmpfile = tempfile.NamedTemporaryFile(dir=tmpdir, suffix='.prom', delete=False)