-
Notifications
You must be signed in to change notification settings - Fork 29
refactor[websocket]: improve websocket factory start #1145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Branch | chore/improve-websocket-factory-start |
Testbed | ubuntu-22.04 |
Click to view all benchmark results
Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Lower Boundary nanoseconds (ns) (Limit %) | Upper Boundary nanoseconds (ns) (Limit %) |
---|---|---|---|---|
sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 101,433,125,219.18 (-0.47%) | 91,721,030,329.48 (90.43%) | 112,103,481,513.80 (90.48%) |
b6e9207
to
132943f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1145 +/- ##
==========================================
- Coverage 84.50% 84.47% -0.04%
==========================================
Files 317 317
Lines 24384 24389 +5
Branches 3707 3709 +2
==========================================
- Hits 20606 20602 -4
- Misses 3069 3072 +3
- Partials 709 715 +6 ☔ View full report in Codecov by Sentry. |
luislhl
commented
Oct 7, 2024
jansegre
previously approved these changes
Oct 7, 2024
msbrogli
requested changes
Oct 7, 2024
132943f
to
59af74d
Compare
msbrogli
approved these changes
Oct 7, 2024
59af74d
to
1dc63f2
Compare
jansegre
approved these changes
Oct 7, 2024
1dc63f2
to
09e7c50
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I had a problem while trying to write a test for
run_node.py
in another PR. The reason was that theHathorAdminWebsocketFactory
was started and never stopped.I noticed that its stop method was never called, and its start was called inside
ResourcesBuilder.create_resources
, which was unlike any other resource we start.I've included a test similar to the one I had problems with to make my difficulties clearer.
Acceptance Criteria
HathorAdminWebsocketFactory
should be started as a consequence of starting the Manager, and should be stopped when the Manager is stoppedChecklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged