-
Notifications
You must be signed in to change notification settings - Fork 29
feat(p2p): support IPv6 #1144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat(p2p): support IPv6 #1144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Branch | feat/ipv6-support-2 |
Testbed | ubuntu-22.04 |
🚨 1 Alert
Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Lower Boundary (Limit %) |
---|---|---|---|---|
sync-v2 (up to 20000 blocks) | Latency nanoseconds (ns) | 📈 plot 🚨 alert (🔔) 🚷 threshold | 87,441,074,608.48 (-13.65%) | 91,133,317,445.79 (104.22%) |
Click to view all benchmark results
Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Lower Boundary nanoseconds (ns) (Limit %) | Upper Boundary nanoseconds (ns) (Limit %) |
---|---|---|---|---|
sync-v2 (up to 20000 blocks) | 📈 view plot 🚨 view alert (🔔) 🚷 view threshold | 87,441,074,608.48 (-13.65%) | 91,133,317,445.79 (104.22%) | 111,385,165,767.07 (78.50%) |
8c37263
to
cce1195
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1144 +/- ##
==========================================
- Coverage 84.93% 84.90% -0.04%
==========================================
Files 323 323
Lines 24985 25044 +59
Branches 3834 3846 +12
==========================================
+ Hits 21222 21263 +41
- Misses 3028 3042 +14
- Partials 735 739 +4 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
5aec274
to
744d84c
Compare
f83ceb0
to
b6e9207
Compare
744d84c
to
6769c47
Compare
b6e9207
to
132943f
Compare
7a772c0
to
1e28b80
Compare
132943f
to
59af74d
Compare
7923006
to
a17535d
Compare
59af74d
to
1dc63f2
Compare
jansegre
previously approved these changes
Oct 7, 2024
1dc63f2
to
09e7c50
Compare
Base automatically changed from
chore/improve-websocket-factory-start
to
master
October 8, 2024 16:03
e04acef
to
8ac5ac6
Compare
jansegre
previously approved these changes
Oct 8, 2024
msbrogli
requested changes
Oct 9, 2024
47ca3b8
to
2dcb6c9
Compare
jansegre
previously approved these changes
Oct 11, 2024
2dcb6c9
to
4a70d1e
Compare
1326268
to
fb5596e
Compare
aba084c
to
7e8e2b9
Compare
msbrogli
approved these changes
Nov 19, 2024
jansegre
approved these changes
Nov 21, 2024
7e8e2b9
to
dcb9a98
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to support IPv6 connections between fullnodes and support exposing their API through IPv6
Acceptance Criteria
--x-enable-ipv6
--x-disable-ipv4
, to make nodes stop connecting to IPv4 endpoints. For now this will be used mostly for tests though, to force a fullnode to behave as IPv6-only.TODO
Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged