refactor(metadata): pre-refactors for migrating feature states to static metadata [part 4/12]

[glevco]

Depends on #1016

---

Motivation

This PR simply removes test asserts related to methods that will be changed in the next PR, #1018:

• FeatureService._calculate_new_state() call count asserts were removed because feature states will only be calculated once for each block, ever.
• FeatureService._get_ancestor_iteratively() call count asserts were removed because this method will be removed.

Those changes required removing with scopes, making the diff very verbose, so a separate PR was created (setting "Hide whitespace" in the diff view makes it way easier to review).

Read the previous PR, #1016, for more info.

Acceptance Criteria

• Remove unnecessary asserts in tests.

Checklist

• If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.61%. Comparing base (5bb5dba) to head (927d482).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1017      +/-   ##
==========================================
- Coverage   84.63%   84.61%   -0.02%     
==========================================
  Files         317      317              
  Lines       24150    24150              
  Branches     3662     3662              
==========================================
- Hits        20439    20435       -4     
- Misses       3006     3009       +3     
- Partials      705      706       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The base branch was changed.

[github-actions]

Bencher

Report	Tue, August 27, 2024 at 14:27:26 UTC
Project	hathor-core
Branch	refactor/metadata/clean-up-refactors-4
Testbed	ubuntu-22.04

Click to view all benchmark results

Benchmark	Latency	Latency Results nanoseconds (ns) | (Δ%)	Latency Lower Boundary nanoseconds (ns) | (%)	Latency Upper Boundary nanoseconds (ns) | (%)
sync-v2 (up to 20000 blocks)	✅ (view plot)	101,437,171,060.38 (-0.91%)	92,136,136,566.14 (90.83%)	112,610,833,580.84 (90.08%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help