refactor(metadata): pre-refactors for migrating feature states to static metadata [part 3/12]

[glevco]

Depends on #1014

---

Motivation

Continuing with the static metadata refactor introduced in PRs #1013 and #1014, the next step is to move the feature_states attribute from metadata to static metadata.

This was initially implemented in PR #1015, which turned out to be too large, so it was divided into 3 PRs: this one, #1017, and #1018. The latter is the one that actually moves the feature_states attribute, and the first two PRs perform simple refactors that were either necessary or small improvements.

Therefore, this PR simply performs some pre-refactors to debloat the main PR.

Acceptance Criteria

• IMPORTANT: move verify_aux_pow() verification from verify_without_storage() to verify().
• Rename FeatureService.get_bits_description() to get_feature_infos(), and FeatureDescription to FeatureInfo.
• Change FeatureService._get_ancestor_at_height() to assert that a block exists in the height index when it must.
• Update the FeatureState enum to be a unique string enum, like Feature (this will be important for serialization), and implement is_active().
• Change static metadata dataclasses to BaseModels instead, which will be necessary for (de)serialization.
• Other smaller improvements.

Checklist

• If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

[codecov]

Codecov Report

Attention: Patch coverage is 92.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.59%. Comparing base (da32f80) to head (112d6dc).

Files	Patch %	Lines
hathor/feature_activation/model/feature_state.py	80.00%	1 Missing ⚠️
hathor/transaction/storage/rocksdb_storage.py	50.00%	1 Missing ⚠️
hathor/verification/block_verifier.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1016      +/-   ##
==========================================
- Coverage   84.62%   84.59%   -0.04%     
==========================================
  Files         317      317              
  Lines       24150    24150              
  Branches     3665     3662       -3     
==========================================
- Hits        20438    20429       -9     
- Misses       3006     3011       +5     
- Partials      706      710       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Bencher

Report	Fri, August 23, 2024 at 21:40:23 UTC
Project	hathor-core
Branch	refactor/metadata/clean-up-refactors-3
Testbed	ubuntu-22.04

Click to view all benchmark results

Benchmark	Latency	Latency Results nanoseconds (ns) | (Δ%)	Latency Lower Boundary nanoseconds (ns) | (%)	Latency Upper Boundary nanoseconds (ns) | (%)
sync-v2 (up to 20000 blocks)	✅ (view plot)	101,529,965,611.26 (-0.90%)	92,204,136,196.06 (90.81%)	112,693,944,239.63 (90.09%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help