Skip to content

integration with new api and update default handling #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

adamfweidman
Copy link
Collaborator

@adamfweidman adamfweidman commented Feb 19, 2024

Changes:

  • Set temporary dependency on google-cloud-synthetics-sdk tgz file during development
  • Update external interfaces to match proto (SyntheticOptions)
  • moved processOptions to options_func.ts -- for purely stylistic/readability reasons
  • update validateInputOptions() to check for acceptable values for new syntheticOptions
  • update setDefaultOptions(): on default set screenshot_condition to 'failing' (only take screenshots of failing links).

@adamfweidman adamfweidman reopened this Feb 19, 2024
@adamfweidman adamfweidman force-pushed the blc-api-integration-def branch from 9dc13a3 to 1b9ff51 Compare February 19, 2024 18:51
@adamfweidman adamfweidman changed the title Blc api integration def integration with new api and update default handling Feb 20, 2024
@adamfweidman adamfweidman force-pushed the blc-api-integration-def branch from 1b9ff51 to f30715c Compare February 20, 2024 20:31
@adamfweidman adamfweidman merged commit 710f524 into final-blc-storage Feb 20, 2024
@adamfweidman adamfweidman deleted the blc-api-integration-def branch February 20, 2024 21:19
adamfweidman added a commit that referenced this pull request Feb 20, 2024
adamfweidman added a commit that referenced this pull request Feb 28, 2024
adamfweidman added a commit that referenced this pull request Feb 28, 2024
adamfweidman added a commit that referenced this pull request Mar 20, 2024
adamfweidman added a commit that referenced this pull request Apr 19, 2024
* get-cloud-region (#100)

Add functionality to synthetics-sdk-api to extract cloud region during GCF execution

* stoage proto api (#101)

* expose resolveProjectId (#104)

* update to capture_condition (#109)

* chore(deps): bump ip from 1.1.8 to 1.1.9 (#105)

* chore(deps): bump ip from 1.1.8 to 1.1.9

Bumps [ip](https://github.com/indutny/node-ip) from 1.1.8 to 1.1.9.
- [Commits](indutny/node-ip@v1.1.8...v1.1.9)

---
updated-dependencies:
- dependency-name: ip
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* Empty-Commit

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Adam Weidman <[email protected]>

* add samples tags (#108)

* blc-api-integration-def (#102)

* resolveProjectId present (#106)

* take-screenshots (#107)

* rebase-capture-condition (#110)

* refactor-integrations (#112)

* sanitize strings (#113)

* Take and populate screenshot (#114)

* screenshots-prop

* broken_links.spec working

* fix naming

* pass-args

* response to comments

* change default (#118)

* update synthetics-sdk-api to point to new npm pkg

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
adamfweidman added a commit that referenced this pull request Apr 19, 2024
adamfweidman added a commit that referenced this pull request Apr 19, 2024
* blc-api-integration-def (#102)

* resolveProjectId present (#106)

* take-screenshots (#107)

* rebase-capture-condition (#110)

* refactor-integrations (#112)

* sanitize strings (#113)

* Take and populate screenshot (#114)

* screenshots-prop

* broken_links.spec working

* fix naming

* pass-args

* response to comments

* change default (#118)

* update synthetics-sdk-api to point to new npm pkg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants