Skip to content

get-cloud-region #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2024
Merged

get-cloud-region #100

merged 1 commit into from
Feb 16, 2024

Conversation

adamfweidman
Copy link
Collaborator

@adamfweidman adamfweidman commented Feb 16, 2024

For better long-term integration and reduced dependencies, I'm implementing this functionality within the synthetics-sdk-api. Placing it directly in the broken-links package would necessitate importing it into future SDKs, creating additional dependencies. This approach ensures reusability across future synthetic SDKs without that overhead.

@adamfweidman adamfweidman force-pushed the get-cloud-region branch 5 times, most recently from 6988f75 to d724a9f Compare February 16, 2024 14:53
@adamfweidman adamfweidman merged commit 4ca6433 into final-api-blc-storage Feb 16, 2024
adamfweidman added a commit that referenced this pull request Mar 20, 2024
Add functionality to synthetics-sdk-api to extract cloud region during GCF execution
adamfweidman added a commit that referenced this pull request Apr 18, 2024
…tExecutionRegion() functionality (#116)

* get-cloud-region (#100)

Add functionality to synthetics-sdk-api to extract cloud region during GCF execution

* stoage proto api (#101)

* expose resolveProjectId (#104)

* update to capture_condition (#109)
adamfweidman added a commit that referenced this pull request Apr 19, 2024
* get-cloud-region (#100)

Add functionality to synthetics-sdk-api to extract cloud region during GCF execution

* stoage proto api (#101)

* expose resolveProjectId (#104)

* update to capture_condition (#109)

* chore(deps): bump ip from 1.1.8 to 1.1.9 (#105)

* chore(deps): bump ip from 1.1.8 to 1.1.9

Bumps [ip](https://github.com/indutny/node-ip) from 1.1.8 to 1.1.9.
- [Commits](indutny/node-ip@v1.1.8...v1.1.9)

---
updated-dependencies:
- dependency-name: ip
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* Empty-Commit

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Adam Weidman <[email protected]>

* add samples tags (#108)

* blc-api-integration-def (#102)

* resolveProjectId present (#106)

* take-screenshots (#107)

* rebase-capture-condition (#110)

* refactor-integrations (#112)

* sanitize strings (#113)

* Take and populate screenshot (#114)

* screenshots-prop

* broken_links.spec working

* fix naming

* pass-args

* response to comments

* change default (#118)

* update synthetics-sdk-api to point to new npm pkg

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants