Skip to content

chore(dns): remove entries in 'CODEOWNERS' and 'auto-label.yaml' for 'dns' product #13289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

eapl-gemugami
Copy link
Contributor

Description

Follow-up of PR 13281

Checklist

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @eapl-gemugami, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request is a follow-up to PR #13281 and removes entries related to the 'dns' product from the CODEOWNERS and auto-label.yaml files. This likely means the 'dns' product is no longer actively maintained or has been moved elsewhere.

Highlights

  • CODEOWNERS Update: The /dns/**/* entry has been removed from the .github/CODEOWNERS file, which means that changes to the dns directory will no longer automatically assign reviewers from the @GoogleCloudPlatform/dee-infra, @GoogleCloudPlatform/python-samples-reviewers, and @GoogleCloudPlatform/cloud-samples-reviewers groups.
  • auto-label.yaml Update: The dns: "dns" entry has been removed from the .github/auto-label.yaml file. This means that pull requests with changes in the dns directory will no longer be automatically labeled with the dns label.

Changelog

  • .github/CODEOWNERS
    • Removed the line /dns/**/* @GoogleCloudPlatform/dee-infra @GoogleCloudPlatform/python-samples-reviewers @GoogleCloudPlatform/cloud-samples-reviewers (line 23).
  • .github/auto-label.yaml
    • Removed the line dns: "dns" (line 46) from the path section.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


A label removed,
Code ownership shifted now,
The DNS takes flight.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@product-auto-label product-auto-label bot added api: dns Issues related to the Cloud DNS API. samples Issues that are directly related to samples. labels Apr 3, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request removes entries related to the 'dns' product from the CODEOWNERS and auto-label.yaml files. The changes seem straightforward and address the issue described in the pull request description.

Merge Readiness

The pull request appears to be ready for merging, as it simply removes entries from configuration files. There are no critical or high severity issues. I am unable to directly approve the pull request, and other reviewers should review and approve this code before merging.

@eapl-gemugami eapl-gemugami added the snippet-bot:force-run Force snippet-bot runs its logic label Apr 3, 2025
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Apr 3, 2025
@eapl-gemugami eapl-gemugami marked this pull request as ready for review April 3, 2025 23:51
@eapl-gemugami eapl-gemugami requested review from a team as code owners April 3, 2025 23:51
@briandorsey briandorsey merged commit 314c158 into GoogleCloudPlatform:main Apr 4, 2025
11 checks passed
@eapl-gemugami eapl-gemugami deleted the paradalicea/chore/dns/fix-github-config branch April 4, 2025 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: dns Issues related to the Cloud DNS API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants