Skip to content

chore(dns): delete all samples in the directory #13281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

eapl-gemugami
Copy link
Contributor

@eapl-gemugami eapl-gemugami commented Apr 1, 2025

Description

Fixes Internal:
b/347349999 create_zone
b/347350146 delete_zone
b/347349945 get_zone
b/347350006 list_zones
b/347350527 list_resource_records
b/347350390 changes

Note to reviewers: All the samples were requested to be removed as they are not being used in documentation. This leads to deleting the whole folder.
I'm wondering if the following entries should be deleted as well: .github/auto-label.yaml#L46 and .github/CODEOWNERS#L23

Checklist

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @eapl-gemugami, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request removes the Google Cloud DNS samples located in the dns/api directory. The PR description indicates that these samples are no longer used in documentation and their removal was requested. The changes involve deleting the sample code, its associated README files, test files, and configuration files.

Highlights

  • Removal of DNS Samples: The primary change is the deletion of all files within the dns/api directory, effectively removing the Google Cloud DNS samples.
  • README Deletion: The README.rst and README.rst.in files associated with the samples have been removed.
  • Sample Code Deletion: The main sample code file, main.py, has been deleted.
  • Test Code Deletion: The test file, main_test.py, and related test requirements file requirements-test.txt have been deleted.
  • Configuration File Deletion: The noxfile_config.py file, which configures the test environment, has been deleted.
  • Dependencies File Deletion: The requirements.txt file, which lists the project dependencies, has been deleted.

Changelog

Click here to see the changelog
  • dns/api/README.rst
    • Deleted the entire README.rst file.
  • dns/api/README.rst.in
    • Deleted the entire README.rst.in file.
  • dns/api/main.py
    • Deleted the entire main.py file.
  • dns/api/main_test.py
    • Deleted the entire main_test.py file.
  • dns/api/noxfile_config.py
    • Deleted the entire noxfile_config.py file.
  • dns/api/requirements-test.txt
    • Deleted the entire requirements-test.txt file.
  • dns/api/requirements.txt
    • Deleted the entire requirements.txt file.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


The samples depart,
No longer in the code's heart,
A cleanup so neat,
A fresh start, bittersweet,
Docs guide a brand new art.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the DNS samples from the repository. The changes involve deleting the entire dns/api directory, including the README, main script, tests, and configuration files. Additionally, the pull request description mentions the need to update .github/auto-label.yaml and .github/CODEOWNERS to reflect the removal of these samples, though these files are not included in the diff.

Summary of Findings

  • Completeness of Removal: The pull request removes the DNS samples directory, but it's important to ensure that all references to these samples are also removed from other parts of the repository, such as the auto-label configuration and CODEOWNERS file, as mentioned in the description.

Merge Readiness

The removal of the DNS samples directory seems straightforward. However, the pull request description mentions the need to update .github/auto-label.yaml and .github/CODEOWNERS, which are not included in the diff. Before merging, it's crucial to ensure that these files are updated to reflect the removal of the samples. I am unable to approve this pull request, and recommend that another reviewer approves this code before merging.

@product-auto-label product-auto-label bot added api: dns Issues related to the Cloud DNS API. samples Issues that are directly related to samples. labels Apr 1, 2025
@iennae
Copy link
Contributor

iennae commented Apr 1, 2025

@eapl-gemugami great catch! I recommend doing a follow-up PR to delete those configurations once the deletion of the directory is merged. Thanks!

@eapl-gemugami eapl-gemugami added the snippet-bot:force-run Force snippet-bot runs its logic label Apr 1, 2025
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Apr 1, 2025
Copy link

snippet-bot bot commented Apr 1, 2025

Here is the summary of changes.

You are about to delete 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@eapl-gemugami eapl-gemugami marked this pull request as ready for review April 1, 2025 17:40
@eapl-gemugami eapl-gemugami requested review from a team as code owners April 1, 2025 17:40
@eapl-gemugami eapl-gemugami merged commit ca8cf68 into GoogleCloudPlatform:main Apr 1, 2025
11 checks passed
@eapl-gemugami eapl-gemugami deleted the paradalicea/chore/dns/delete-unused-samples branch April 1, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: dns Issues related to the Cloud DNS API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants