Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(compute): migrate to new CI #4058

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

chore(compute): migrate to new CI #4058

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
36671f7
chore(compute): migrate to new CI
glasnt Apr 2, 2025
bdbfa20
remove old workflow
glasnt Apr 2, 2025
d09a8de
force re-run (revert)
glasnt Apr 2, 2025
b732af1
debug: affected panic
glasnt Apr 2, 2025
1805b8b
empty ci-setup.json != no config
glasnt Apr 2, 2025
f23736f
remove debug
glasnt Apr 2, 2025
0a6b420
extend tests time
glasnt Apr 2, 2025
82162c2
try parallel
glasnt Apr 2, 2025
63e6cc3
make failing tests more linear in a parallel world
glasnt Apr 4, 2025
b9e2adf
lint
glasnt Apr 4, 2025
7be6f98
delete order might be important
glasnt Apr 4, 2025
df15ca2
debug why broke
glasnt Apr 4, 2025
57f3a06
increase job parallel
glasnt Apr 4, 2025
789d8f9
Merge branch 'main' into ci-compute
glasnt Apr 4, 2025
d7c3bb5
lint
glasnt Apr 4, 2025
68bcb0f
more parallel, more problems
glasnt Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/config/nodejs-dev.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@
"cloudbuild",
"composer",
"composer/functions/composer-storage-trigger",
"compute",
Comment on lines 111 to +112
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Adding 'compute' here will include it in the development CI runs. Ensure this is the desired behavior and that the compute sample is ready for these runs.

   "compute",

"contact-center-insights",
"container",
"container-analysis/snippets",
Expand Down
1 change: 0 additions & 1 deletion .github/config/nodejs-prod.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@
"automl", // (untested) FAILED_PRECONDITION: Google Cloud AutoML Natural Language was retired on March 15, 2024. Please migrate to Vertex AI instead
"cloud-sql/sqlserver/mssql", // (untested) TypeError: The "config.server" property is required and must be of type string.
"cloud-sql/sqlserver/tedious", // (untested) TypeError: The "config.server" property is required and must be of type string.
"compute", // GoogleError: The resource 'projects/long-door-651/zones/us-central1-a/disks/disk-from-pool-name' was not found
Comment on lines 81 to -82
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Removing 'compute' from the production CI runs suggests there were issues with it. Ensure the comment accurately reflects the reason for removal and that there's a plan to re-enable it once the issues are resolved.

    "compute", // GoogleError: The resource 'projects/long-door-651/zones/us-central1-a/disks/disk-from-pool-name' was not found

"dataproc", // GoogleError: Error submitting create cluster request: Multiple validation errors
"datastore/functions", // [ERR_REQUIRE_ESM]: require() of ES Module
"dialogflow-cx", // NOT_FOUND: com.google.apps.framework.request.NotFoundException: Agent 'undefined' does not exist
Expand Down
Empty file added compute/ci-setup.json
View file
Open in desktop
Empty file.
Loading