Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(compute): migrate to new CI #4058

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

chore(compute): migrate to new CI #4058

wants to merge 16 commits into from

Conversation

glasnt
Copy link
Contributor

@glasnt glasnt commented Apr 2, 2025

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @glasnt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request is a chore to migrate to the new CI. It involves changes to two files: .github/config/nodejs-dev.jsonc and .github/config/nodejs-prod.jsonc. The change adds compute to the list of directories in nodejs-dev.jsonc and removes compute from the list of directories in nodejs-prod.jsonc.

Highlights

  • CI Migration: The primary goal is to update the CI configuration by migrating the compute samples.
  • Configuration Changes: The pull request modifies the lists of directories in nodejs-dev.jsonc and nodejs-prod.jsonc to reflect the new CI setup.

Changelog

  • .github/config/nodejs-dev.jsonc
    • Added compute to the list of directories to be included in the CI runs. Line 112.
  • .github/config/nodejs-prod.jsonc
    • Removed compute from the list of directories to be excluded from the CI runs. Line 82.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


A config file's gentle shift,
Compute's place, a subtle gift.
From prod it's gone,
In dev it's drawn,
CI's dance, a coding lift.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@product-auto-label product-auto-label bot added api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples. labels Apr 2, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request migrates the compute sample to the new CI. The changes involve adding 'compute' to the nodejs-dev.jsonc file and removing it from the nodejs-prod.jsonc file. This seems like a straightforward update to the CI configuration.

Merge Readiness

The pull request appears to be a simple configuration update for the CI. Since the changes are limited to configuration files and seem to address a specific issue, it should be safe to merge after verification that the compute sample is now correctly handled by the CI. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging.

Comment on lines 111 to +112
"composer/functions/composer-storage-trigger",
"compute",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Adding 'compute' here will include it in the development CI runs. Ensure this is the desired behavior and that the compute sample is ready for these runs.

   "compute",

Comment on lines 81 to -82
"cloud-sql/sqlserver/tedious", // (untested) TypeError: The "config.server" property is required and must be of type string.
"compute", // GoogleError: The resource 'projects/long-door-651/zones/us-central1-a/disks/disk-from-pool-name' was not found
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Removing 'compute' from the production CI runs suggests there were issues with it. Ensure the comment accurately reflects the reason for removal and that there's a plan to re-enable it once the issues are resolved.

    "compute", // GoogleError: The resource 'projects/long-door-651/zones/us-central1-a/disks/disk-from-pool-name' was not found

@glasnt glasnt mentioned this pull request Apr 2, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant