Skip to content

ci(eventarc): onboard pubsub sample to testing isolation #3988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 28, 2025
Merged

ci(eventarc): onboard pubsub sample to testing isolation #3988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7863a1a
ci(eventarc): onboard pubsub sample to testing isolation
glasnt Feb 25, 2025
58b628e
add new envvar, add custom random suffix code (WIP)
glasnt Feb 25, 2025
7aaaf15
try different random suffix generator
glasnt Feb 25, 2025
2a8fe81
debug current account
glasnt Feb 26, 2025
e07fa63
use RUN_ID as randomization
glasnt Feb 26, 2025
6da3ab4
cleanup test given new envvars
glasnt Feb 28, 2025
3fe50e1
Merge branch 'main' into ariwete-eventarc-pubsub
glasnt Feb 28, 2025
045a8d0
add audience
glasnt Feb 28, 2025
94f6c5a
correct audience
glasnt Feb 28, 2025
e8fc383
remove unneeded params
glasnt Feb 28, 2025
fe86023
exclude from dev
davidcavazos Feb 28, 2025
92ce5b5
Merge branch 'main' into ariwete-eventarc-pubsub
davidcavazos Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/config/nodejs-dev.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@
"endpoints/getting-started-grpc",
"error-reporting",
"eventarc/generic",
"eventarc/pubsub",
"functions/concepts/afterResponse",
"functions/concepts/afterTimeout",
"functions/concepts/backgroundTermination",
Expand Down
1 change: 0 additions & 1 deletion .github/config/nodejs-prod.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@
"dlp", // [ERR_REQUIRE_ESM]: require() of ES Module
"document-ai", // [ERR_REQUIRE_ESM]: require() of ES Module
"eventarc/audit-storage", // (untested) Environment Variable 'SERVICE_NAME' not found
"eventarc/pubsub", // (untested) Environment Variable 'SERVICE_NAME' not found
"functions/billing", // Error: Request failed with status code 500
"functions/http/uploadFile", // npm error Missing script: "test"
"functions/imagemagick", // Error: A bucket name is needed to use Cloud Storage
Expand Down
6 changes: 6 additions & 0 deletions eventarc/pubsub/ci-setup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"env": {
"SERVICE_NAME": "eventarc-pubsub-${RUN_ID}",
"CONTAINER_IMAGE": "gcr.io/long-door-651/eventarc-pubsub:${RUN_ID}"
}
}
3 changes: 3 additions & 0 deletions eventarc/pubsub/test/deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ requireEnv() {

requireEnv SERVICE_NAME
requireEnv CONTAINER_IMAGE
requireEnv SERVICE_ACCOUNT

# Build the service
set -x
Expand All @@ -35,6 +36,8 @@ gcloud run deploy "${SERVICE_NAME}" \
--region="${REGION:-us-central1}" \
${FLAGS} \
--platform=managed \
--service-account="${SERVICE_ACCOUNT}" \
--add-custom-audiences="https://action.test/" \
--quiet
set +x

Expand Down
6 changes: 3 additions & 3 deletions eventarc/pubsub/test/runner.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ requireEnv() {
test "${!1}" || (echo "Environment Variable '$1' not found" && exit 1)
}
requireEnv SERVICE_NAME
requireEnv CONTAINER_IMAGE
requireEnv SERVICE_ACCOUNT
requireEnv ID_TOKEN

echo '---'
test/deploy.sh
Expand All @@ -33,14 +36,11 @@ echo
function cleanup {
set -x
gcloud run services delete ${SERVICE_NAME} \
--platform=managed \
--region="${REGION:-us-central1}" \
--quiet
}
trap cleanup EXIT

# TODO: Perform authentication inside the test.
export ID_TOKEN=$(gcloud auth print-identity-token)
export BASE_URL=$(test/url.sh)

test -z "$BASE_URL" && echo "BASE_URL value is empty" && exit 1
Expand Down
Loading