Skip to content

ci(eventarc): onboard pubsub sample to testing isolation #3988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Feb 28, 2025
Merged

ci(eventarc): onboard pubsub sample to testing isolation #3988

merged 12 commits into from
Feb 28, 2025

Conversation

glasnt
Copy link
Contributor

@glasnt glasnt commented Feb 25, 2025 •
edited by davidcavazos
Loading

Adds eventarc/pubsub to new testing infra

  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added api: eventarc Issues related to the Eventarc API. samples Issues that are directly related to samples. asset: pattern DEE Asset tagging - Pattern. labels Feb 25, 2025
@glasnt glasnt marked this pull request as ready for review February 28, 2025 02:04
@glasnt glasnt requested review from a team as code owners February 28, 2025 02:04
@davidcavazos
Copy link
Contributor

This also needs to add eventarc/pubsub into the dev exclude list to avoid running it both in prod and dev.

@davidcavazos davidcavazos merged commit 5a1e566 into main Feb 28, 2025
13 checks passed
@davidcavazos davidcavazos deleted the ariwete-eventarc-pubsub branch February 28, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidcavazos davidcavazos davidcavazos approved these changes

Assignees
No one assigned
Labels
api: eventarc Issues related to the Eventarc API. asset: pattern DEE Asset tagging - Pattern. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glasnt @davidcavazos