fix: fix permanent diff in SQLInstance backupConfiguration

[jingyih]

This PR

• Add a test case to reproduce Empty updates to GCP during SQLInstance reconciliation #4207
• Fix the permanent diff in backupConfiguration for SQLInstance. This is a behavior change introduced when migrating the resource from the TF controller to the direct controller. The fix effectively reverts the behavior change.

Fixes: #4207

Without the change:

$ go test -v -tags=integration ./pkg/controller/dynamic/ -run TestCreateNoChangeUpdateDelete/sql/basic-sqlinstance-backupconfiguration-diff 
...
k8s.go:84: expected event with reason 'Updating' to not be recorded for SQLInstance pxx4um5zs4ihvqa/test-pxx4um5zs4ihvqa, but it was
...
--- FAIL: TestCreateNoChangeUpdateDelete (0.17s)
    --- FAIL: TestCreateNoChangeUpdateDelete/sql (0.00s)
        --- FAIL: TestCreateNoChangeUpdateDelete/sql/basic-sqlinstance-backupconfiguration-diff  (310.95s)
FAIL

With the change

$ go test -v -tags=integration ./pkg/controller/dynamic/ -run TestCreateNoChangeUpdateDelete/sql/basic-sqlinstance-backupconfiguration-diff 
...
--- PASS: TestCreateNoChangeUpdateDelete (0.22s)
    --- PASS: TestCreateNoChangeUpdateDelete/sql (0.00s)
        --- PASS: TestCreateNoChangeUpdateDelete/sql/basic-sqlinstance-backupconfiguration-diff (1037.23s)
PASS

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jingyih. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jingyih]

Ah, this test does NOT wait for the next reconciliation to occur after the first one which successfully creates the GCP resource.

/close

[google-oss-prow]

@jingyih: Closed this PR.

In response to this:

Ah, this test does NOT wait for the next reconciliation to occur after the first one which successfully creates the GCP resource.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jingyih]

I was able to reproduce this using a different test flow.

$ go test -v -tags=integration ./pkg/controller/dynamic/ -run TestCreateNoChangeUpdateDelete/sql/basic-issue-4207
...
k8s.go:84: expected event with reason 'Updating' to not be recorded for SQLInstance pxx4um5zs4ihvqa/test-pxx4um5zs4ihvqa, but it was
...
--- FAIL: TestCreateNoChangeUpdateDelete (0.17s)
    --- FAIL: TestCreateNoChangeUpdateDelete/sql (0.00s)
        --- FAIL: TestCreateNoChangeUpdateDelete/sql/basic-issue-4207 (310.95s)
FAIL

Despite the spec in the YAML configuration is not changed, we are seeing a diff in the controller.

[jingyih]

Moved this line from 306 for better readability.

[yuwenma]

Could you remove the reference to 4207 (or use 4230 instead) in the PR description and test suite names? Otherwise it could cause confusions.

[jingyih]

Could you remove the reference to 4207 (or use 4230 instead) in the PR description and test suite names? Otherwise it could cause confusions.

Renamed test case to sqlinstance-backupconfiguration-diff.