chore: add test for issue 4207

Author: jingyih

pkg/controller/direct/sql/sqlinstance_controller.go

@@ -112,6 +112,8 @@ func (a *sqlInstanceAdapter) Find(ctx context.Context) (bool, error) {
 		return false, nil
 	}
 
+	fmt.Printf("[debug] finding SQLInstance %s\n", a.resourceID)
+
 	instance, err := a.sqlInstancesClient.Get(a.projectID, a.resourceID).Context(ctx).Do()
 	if err != nil {
 		return false, nil
@@ -180,6 +182,8 @@ func (a *sqlInstanceAdapter) insertInstance(ctx context.Context, u *unstructured
 		return err
 	}
 
+	fmt.Printf("[debug] inserting SQLInstance %+v\n", desiredGCP)
+
 	op, err := a.sqlInstancesClient.Insert(a.projectID, desiredGCP).Context(ctx).Do()
 	if err != nil {
 		return fmt.Errorf("creating SQLInstance %s failed: %w", a.desired.Name, err)
@@ -287,9 +291,13 @@ func (a *sqlInstanceAdapter) Update(ctx context.Context, updateOp *directbase.Up
 		return err
 	}
 
+	fmt.Printf("[debug] desiredGCP: %+v\n", desiredGCP)
+	fmt.Printf("[debug] a.actual: %+v\n", a.actual)
+	fmt.Printf("[debug] InstancesMatch(desiredGCP, a.actual): %+v\n", InstancesMatch(desiredGCP, a.actual))
 	if !InstancesMatch(desiredGCP, a.actual) {
 		updateOp.RecordUpdatingEvent()
 
+		fmt.Printf("[debug] making a GCP call to update %s\n", desiredGCP.Name)
 		op, err := a.sqlInstancesClient.Update(a.projectID, desiredGCP.Name, desiredGCP).Context(ctx).Do()
 		if err != nil {
 			return fmt.Errorf("updating SQLInstance %s failed: %w", desiredGCP.Name, err)

pkg/test/resourcefixture/testdata/basic/sql/v1beta1/sqlinstance/issue-4207/_generated_object_issue-4207.golden.yaml

@@ -0,0 +1,62 @@
+apiVersion: sql.cnrm.cloud.google.com/v1beta1
+kind: SQLInstance
+metadata:
+  annotations:
+    cnrm.cloud.google.com/deletion-policy: abandon
+    cnrm.cloud.google.com/management-conflict-prevention-policy: none
+    cnrm.cloud.google.com/mutable-but-unreadable-fields: '{}'
+    cnrm.cloud.google.com/observed-secret-versions: (removed)
+    cnrm.cloud.google.com/project-id: ${projectId}
+    cnrm.cloud.google.com/state-into-spec: absent
+  finalizers:
+  - cnrm.cloud.google.com/finalizer
+  - cnrm.cloud.google.com/deletion-defender
+  generation: 1
+  labels:
+    cnrm-test: "true"
+  name: test-${uniqueId}
+  namespace: ${uniqueId}
+spec:
+  databaseVersion: POSTGRES_13
+  region: europe-west3
+  resourceID: test-${uniqueId}
+  settings:
+    availabilityType: REGIONAL
+    backupConfiguration:
+      backupRetentionSettings:
+        retainedBackups: 30
+      enabled: true
+      pointInTimeRecoveryEnabled: true
+    databaseFlags:
+    - name: temp_file_limit
+      value: "3145728"
+    deletionProtectionEnabled: true
+    diskSize: 10
+    insightsConfig:
+      queryInsightsEnabled: true
+    ipConfiguration:
+      requireSsl: true
+    tier: db-g1-small
+status:
+  conditions:
+  - lastTransitionTime: "1970-01-01T00:00:00Z"
+    message: The resource is up to date
+    reason: UpToDate
+    status: "True"
+    type: Ready
+  connectionName: ${projectId}:europe-west3:test-${uniqueId}
+  firstIpAddress: 10.1.2.3
+  instanceType: CLOUD_SQL_INSTANCE
+  ipAddress: 10.1.2.3
+  observedGeneration: 1
+  publicIpAddress: 10.1.2.3
+  selfLink: https://sqladmin.googleapis.com/sql/v1beta4/projects/${projectId}/instances/test-${uniqueId}
+  serverCaCert:
+    cert: |
+      -----BEGIN CERTIFICATE-----
+      -----END CERTIFICATE-----
+    commonName: common-name
+    createTime: "1970-01-01T00:00:00Z"
+    expirationTime: "1970-01-01T00:00:00Z"
+    sha1Fingerprint: "12345678"
+  serviceAccountEmailAddress: p${projectNumber}[email protected]