feat: Add CloudIdentityGroup direct controller #3653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gemmahou
force-pushed
the
cloudidentitygroup-controller
branch
8 times, most recently
from
b9b4e50 to
9e8805c
Compare
gemmahou
force-pushed
the
cloudidentitygroup-controller
branch
5 times, most recently
from
23bdb84 to
50f747a
Compare
gemmahou
force-pushed
the
cloudidentitygroup-controller
branch
7 times, most recently
from
b14dea9 to
11ba115
Compare
gemmahou
commented
Apr 24, 2025
...re/testdata/basic/cloudidentity/v1beta1/cloudidentitygroup/cloudidentitygroupbasic/_http.log
Show resolved
Hide resolved
gemmahou
commented
Apr 24, 2025
...re/testdata/basic/cloudidentity/v1beta1/cloudidentitygroup/cloudidentitygroupbasic/_http.log
Show resolved
Hide resolved
jingyih
reviewed
Apr 29, 2025
barney-s
reviewed
Apr 29, 2025
...re/testdata/basic/cloudidentity/v1beta1/cloudidentitygroup/cloudidentitygroupbasic/_http.log
Show resolved
Hide resolved
gemmahou
force-pushed
the
cloudidentitygroup-controller
branch
from
bfa2e89 to
a1347b7
Compare
|
/lgtm |
3 tasks
jingyih
reviewed
May 3, 2025
| @@ -154,7 +154,7 @@ func (s *groupsServer) PatchGroup(ctx context.Context, req *pb.PatchGroupRequest | |||
| for _, path := range strings.Split(req.GetUpdateMask(), ",") { | |||
| switch path { | |||
| case "displayName": // TF controller uses displayName while direct controller uses display_name | |||
| obj.DisplayName = req.GetGroup().DisplayName // TF | |||
| fallthrough | |||
There was a problem hiding this comment.
nit: maybe case "displayName", "display_name": would be less error-prone for future edits?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingyih The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jingyih
reviewed
May 3, 2025
| name: ${groupID} | ||
| observedGeneration: 3 | ||
| externalRef: groups/${groupID} | ||
| name: groups/${groupID} |
There was a problem hiding this comment.
Oh, just realized this is a TF beta resource?
We need to ensure backward compatabiilty. So status.name should not have "groups/" prefix. And we should write back "spec.resourceID".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Add CloudIdentityGroup direct controller.
Tests you have done
Duplicated code to GoB and triggered realGCP test: https://cnrm-review.git.corp.google.com/c/cnrm/+/72600
(Test failure is expected, since we start a new pipeline for each run, there's no golden log to compare with. Other than the diff I don't see other errors)
RealGCP log saved in GCS: https://pantheon.corp.google.com/storage/browser/cnrm-prow/pr-logs/pull/cnrm-review.googlesource.com_cnrm/72600/cnrm-test/1915192728967188480/artifacts;tab=objects?e=13802955&mods=pan_ng2&prefix=&forceOnObjectsSortingFiltering=false
diff between TF-mock and direct-real: aa34cc3
diff between direct-real and direct-mock(no diff): 11ba115
make ready-prto ensure this PR is ready for review.