Skip to content

common.CompareProtoMessage function does not work on proto fields without annotation #4455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
3 tasks done
gemmahou opened this issue May 1, 2025 · 2 comments
Open
3 tasks done

common.CompareProtoMessage function does not work on proto fields without annotation #4455

gemmahou opened this issue May 1, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@gemmahou
Copy link
Collaborator

gemmahou commented May 1, 2025 •
edited
Loading

Checklist

  • I did not find a related open enhancement request.
  • I understand that enhancement requests filed in the GitHub repository are by default low priority.
  • If this request is time-sensitive, I have submitted a corresponding issue with GCP support.

Describe the feature or resource

The CompareProtoMessage function checks proto annotation to determine output-only fields, and immutable fields but it has certain limitations:

See comment: #3653 (comment)

I've also noticed that compute resources do not have that annotation: https://screenshot.googleplex.com/BxLQE5WtTjJPTRd.png

Additional information

No response

Importance

No response
@gemmahou gemmahou added the enhancement New feature or request label May 1, 2025
@gemmahou
Copy link
Collaborator Author

gemmahou commented May 1, 2025

cc: @yuwenma

@gemmahou gemmahou mentioned this issue May 2, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gemmahou