Regenerate speech API. Now it contains streamingRecognize method.

[jmuk]

This does not change src/index.js yet.

[stephenplusplus]

I've tried to integrate this with src/index, and it seems to work, except for the response event. Does gax expose a way to get the API's raw response? Currently:

speech.createRecognizeStream({...})
  .on('response', function(response) {
    response === {
      "code": 200,
      "details": "",
      "metadata": {
        "_internal_repr": {
          "content-disposition": [
            "attachment"
          ]
        }
      },
      "message": "OK"
    }
  })
  .on('data', function() {...})

[stephenplusplus]

@jmuk to clarify, this response is from the grpc stream event named metadata: https://github.com/GoogleCloudPlatform/google-cloud-node/blob/116436fa789d8b0f7fc5100b19b424e3ec63e6bf/packages/common/src/grpc-service.js#L355

We rename it to response as its more common for users familiar with the tradition HTTP request/response workflow, with the response event being standard with the Node.js native HTTP module: https://nodejs.org/api/http.html#http_event_response

[jmuk]

I see. It seems gax loses metadata and status event which gRPC supplies. Filed as googleapis/gax-nodejs#67 and I'm on it.

[jmuk]

Could it be status instead of metadata which we want for response?

[stephenplusplus]

Maybe, what is the difference between the status and response objects?

[jmuk]

metadata only contains the part of {metadata: {_internal_repr: { ... }}} while status provides what you wrote -- including code or something. And it seems status comes at the end of the stream while metadata comes earlier.

[stephenplusplus]

@callmehiphop wdyt? I think you were more closely connected with our implementation.

[callmehiphop]

I think something to note is that status and metadata occur at different times. Where metadata happens once the request starts, status doesn't happen until after all results have been processed.

For that reason alone, I think in the veneer layer we typically listen for metadata.

[jmuk]

Ah, okay. So https://github.com/GoogleCloudPlatform/google-cloud-node/blob/116436fa789d8b0f7fc5100b19b424e3ec63e6bf/packages/common/src/grpc-service.js#L355 does take 'metadata' event, and create the response object with "code: 0" (i.e. succeeds). I'll do the same thing.

[jmuk]

Now it's added.

[stephenplusplus]

I added a commit to use the new streaming method from our API.

@callmehiphop could you take a look and push a commit that gets rid of anything we don't need, re: GrpcService?

[coveralls]

Coverage remained the same at 100.0% when pulling 0c79f2b on jmuk:speech into 116436f on GoogleCloudPlatform:master.

[callmehiphop]

@stephenplusplus I don't think you can cut out GrpcService unless GAX also supports LRO.

[stephenplusplus]

Okay, thanks for taking a look.