Skip to content

Commit 0c79f2b

Browse files
speech: use streaming API
1 parent e6ebda2 commit 0c79f2b

File tree

2 files changed

+39
-40
lines changed

2 files changed

+39
-40
lines changed

packages/speech/src/index.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -472,18 +472,13 @@ Speech.formatResults_ = function(resultSets, verboseMode) {
472472
Speech.prototype.createRecognizeStream = function(config) {
473473
var self = this;
474474

475-
var protoOpts = {
476-
service: 'Speech',
477-
method: 'streamingRecognize'
478-
};
479-
480475
var verboseMode = config.verbose === true;
481476
delete config.verbose;
482477

483478
var recognizeStream = streamEvents(pumpify.obj());
484479

485480
recognizeStream.once('writing', function() {
486-
var requestStream = self.requestWritableStream(protoOpts);
481+
var requestStream = self.api.Speech.streamingRecognize();
487482

488483
requestStream.on('response', function(response) {
489484
recognizeStream.emit('response', response);

packages/speech/test/index.js

Lines changed: 38 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -448,22 +448,20 @@ describe('Speech', function() {
448448

449449
stream.setPipeline = util.noop;
450450

451-
speech.requestWritableStream = function() {
452-
requestStream = through.obj();
453-
return requestStream;
451+
speech.api.Speech = {
452+
streamingRecognize: function() {
453+
requestStream = through.obj();
454+
return requestStream;
455+
}
454456
};
455457
});
456458

457459
it('should make the correct request once writing started', function(done) {
458-
speech.requestWritableStream = function(protoOpts) {
459-
assert.deepEqual(protoOpts, {
460-
service: 'Speech',
461-
method: 'streamingRecognize'
462-
});
463-
464-
setImmediate(done);
465-
466-
return through.obj();
460+
speech.api.Speech = {
461+
streamingRecognize: function() {
462+
setImmediate(done);
463+
return through.obj();
464+
}
467465
};
468466

469467
stream.emit('writing');
@@ -477,31 +475,35 @@ describe('Speech', function() {
477475
done();
478476
});
479477

480-
speech.requestWritableStream = function() {
481-
var requestStream = through.obj();
478+
speech.api.Speech = {
479+
streamingRecognize: function() {
480+
var requestStream = through.obj();
482481

483-
setImmediate(function() {
484-
requestStream.emit('response', response);
485-
});
482+
setImmediate(function() {
483+
requestStream.emit('response', response);
484+
});
486485

487-
return requestStream;
486+
return requestStream;
487+
}
488488
};
489489

490490
stream.emit('writing');
491491
});
492492

493493
it('should send the initial write to the request stream', function(done) {
494-
speech.requestWritableStream = function() {
495-
var requestStream = through.obj();
494+
speech.api.Speech = {
495+
streamingRecognize: function() {
496+
var requestStream = through.obj();
496497

497-
requestStream.once('data', function(data) {
498-
assert.deepEqual(data, {
499-
streamingConfig: CONFIG
498+
requestStream.once('data', function(data) {
499+
assert.deepEqual(data, {
500+
streamingConfig: CONFIG
501+
});
502+
done();
500503
});
501-
done();
502-
});
503504

504-
return requestStream;
505+
return requestStream;
506+
}
505507
};
506508

507509
stream.emit('writing');
@@ -582,17 +584,19 @@ describe('Speech', function() {
582584
verbose: true
583585
});
584586

585-
speech.requestWritableStream = function() {
586-
var stream = through.obj();
587+
speech.api.Speech = {
588+
streamingRecognize: function() {
589+
var stream = through.obj();
587590

588-
stream.on('data', function(data) {
589-
assert.deepEqual(data, {
590-
streamingConfig: {} // No `verbose` property.
591+
stream.on('data', function(data) {
592+
assert.deepEqual(data, {
593+
streamingConfig: {} // No `verbose` property.
594+
});
595+
done();
591596
});
592-
done();
593-
});
594597

595-
return stream;
598+
return stream;
599+
}
596600
};
597601

598602
stream.emit('writing');

0 commit comments

Comments
 (0)