Support more gRPC streaming events. #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 'metadata' and 'status' events are meaningful and should be forwarded. - gRPC streaming results have 'cancel' method, this method call needs to be forwarded as well. Fixes googleapis#67
Current coverage is 92.23% (diff: 83.33%)@@ master #68 diff @@
==========================================
Files 9 9
Lines 993 1004 +11
Methods 148 151 +3
Messages 0 0
Branches 210 212 +2
==========================================
+ Hits 916 926 +10
- Misses 77 78 +1
Partials 0 0
|
geigerj
reviewed
Nov 8, 2016
| if (this.type !== StreamType.CLIENT_STREAMING) { | ||
| stream.on('data', this.emit.bind(this, 'data')); | ||
| // Pushing null causes an ending process of the readable stream. | ||
| stream.on('end', this.push.bind(this, null)); | ||
| // This is required in case there's no 'data' handler exists. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| stream.on(event, this.emit.bind(this, event)); | ||
| }.bind(this)); | ||
| // We also want to supply the status data as 'response'. | ||
| stream.on('status', this.emit.bind(this, 'response')); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| if (this.type !== StreamType.CLIENT_STREAMING) { | ||
| stream.on('data', this.emit.bind(this, 'data')); | ||
| // Pushing null causes an ending process of the readable stream. | ||
| stream.on('end', this.push.bind(this, null)); | ||
| // This is required in case there's no 'data' handler exists. | ||
| this.resume(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
geigerj
approved these changes
Nov 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forwarded.
needs to be forwarded as well.
Fixes #67