Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update a few references from 3-project-factory to 2-project-factory #2568

Merged
merged 5 commits into from
Sep 19, 2024

Conversation

lyricnz
Copy link
Contributor

@lyricnz lyricnz commented Sep 14, 2024

The move of project-factory from stage 3 to stage 2 #2567 appears to have missed a couple of places


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Copy link

google-cla bot commented Sep 14, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@lyricnz lyricnz marked this pull request as draft September 14, 2024 03:06
@lyricnz
Copy link
Contributor Author

lyricnz commented Sep 14, 2024

Looking into tfdoc and removing unnecessary (whitespace) changes.

@lyricnz lyricnz marked this pull request as ready for review September 14, 2024 03:11
@lyricnz lyricnz changed the title Update 3 project factory Update a few references from 3-project-factory to 2-project-factory Sep 14, 2024
@ludoo ludoo enabled auto-merge (squash) September 18, 2024 08:01
@ludoo ludoo merged commit 9a51c4d into GoogleCloudPlatform:master Sep 19, 2024
14 checks passed
@lyricnz lyricnz deleted the update-3-project-factory branch September 19, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants