Skip to content

Diagram out of date - shows project-factory in stage 3 #2567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lyricnz opened this issue Sep 14, 2024 · 4 comments · Fixed by #2581
Closed

Diagram out of date - shows project-factory in stage 3 #2567

lyricnz opened this issue Sep 14, 2024 · 4 comments · Fixed by #2581

Comments

@lyricnz
Copy link
Contributor

lyricnz commented Sep 14, 2024

Describe the bug
The diagram at https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/raw/master/fast/stages.svg shows project-factory in stage-3, but it's now in stage-2 since #2505

The same issue is in the PNG version, and the tenant-states PNG+SVG

@lyricnz
Copy link
Contributor Author

lyricnz commented Sep 14, 2024

Is there a canonical source for these diagrams, or do we just edit the SVG directly? I notice the diagram also omits:

  • 1-vpcsc
  • 3-gcve

@sruffilli
Copy link
Collaborator

Hey Simon, nice catch.
I created a slide deck with those diagrams available here

Thanks!

@lyricnz
Copy link
Contributor Author

lyricnz commented Sep 19, 2024

Nice. Is there any way we can do that within the repo? (to reduce breakable external dependencies, and ensure it's updated as part of PRs that change structure/names/etc)

I'm not knowledgable enough to actually update the diagram, btw, especially updating the arrows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants