Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for target_resources to net-firewall-policy module #2012

Conversation

bcorbitt-ps
Copy link
Contributor

Add support for target_resources in hierarchical policy for net-firewall-policy module. (Issue #2011)

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Copy link

google-cla bot commented Jan 25, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for implementing this!

@ludoo ludoo enabled auto-merge (squash) January 25, 2024 17:41
@ludoo ludoo changed the title Issue #2011 - add support for target_resources in hierarchical policy for net-firewall-policy module. Add support for target_resources to net-firewall-policy module Jan 25, 2024
@ludoo ludoo merged commit 9c1afa6 into GoogleCloudPlatform:master Jan 25, 2024
@bcorbitt-ps bcorbitt-ps deleted the bcorbitt-ps/support-target-resources branch February 26, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants