Skip to content

Add support for target_resources to net-firewall-policy module #2011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bcorbitt-ps opened this issue Jan 25, 2024 · 0 comments
Closed

Add support for target_resources to net-firewall-policy module #2011

bcorbitt-ps opened this issue Jan 25, 2024 · 0 comments

Comments

@bcorbitt-ps
Copy link
Contributor

Describe the bug
The net-firewall-policy module does not currently support the target_resources argument for hierarchical firewall policies.

Environment

Terraform v1.6.2
on linux_amd64

output from `git rev-parse --short HEAD`
6d9b6403 (from fork)

To Reproduce
Unable to pass a target subnet locally or via factory for hierarchical rules.

Expected behavior
Would like to have this option available.

Result
When passing via factory YAML, the target_resources parameter is simply ignored.

Additional context
Will submit a PR for this shortly.
bcorbitt-ps added a commit to bcorbitt-ps/cloud-foundation-fabric that referenced this issue Jan 25, 2024
@bcorbitt-ps
Issue GoogleCloudPlatform#2011 - Add support for target_resources in …
6bfcc04 
…hierarchical firewall policy
@bcorbitt-ps bcorbitt-ps mentioned this issue Jan 25, 2024
Merged
4 tasks
ludoo pushed a commit that referenced this issue Jan 25, 2024
@bcorbitt-ps
Issue #2011 - add support for target_resources in hierarchical policy…
9c1afa6 
… for net-firewall-policy module. (#2012)

* Issue #2011 - Add support for target_resources in hierarchical firewall policy

* Removing errant character in factory.tf
@ludoo ludoo closed this as completed Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ludoo @bcorbitt-ps