Skip to content

fix: use daemon threads internally #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025
Merged

fix: use daemon threads internally #618

merged 1 commit into from
Feb 21, 2025

Conversation

enocom
Copy link
Member

@enocom enocom commented Feb 21, 2025

Without using daemon threads, the Connector will prevent a calling process from exiting cleanly.

Fixes #617

Without using daemon threads, the Connector will prevent a calling
process from exiting cleanly.

Fixes #617
@enocom enocom requested a review from a team as a code owner February 21, 2025 15:03
Copy link
Collaborator

@nancynh nancynh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@enocom enocom merged commit 6defeb3 into main Feb 21, 2025
14 checks passed
@enocom enocom deleted the daemon-threads branch February 21, 2025 18:53
@enocom
Copy link
Member Author

enocom commented Feb 21, 2025

@ukarlsson we'll cut a release with this early next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InternalConnectorRegistry.executor uses non-daemon threads
3 participants