InternalConnectorRegistry.executor uses non-daemon threads

[ukarlsson]

Bug Description

For InternalConnectorRegistry.executor, it uses non-daemon threads which prevents normal shutdown of our application. It is very easy to reproduce this for us - whenever we have a command that connects to AlloyDB it does not terminate when the main function exits, and we instead need to put System.exit(0) or ConnectorRegistry.shutdown() at the end of the main function.

It seems like even error on the main thread does not terminate the process now with the connector, so we have batch jobs that fail and linger in this zombie state.

In order to create daemon threads, creation of executors should be changed to something like

this.executor = MoreExecutors.listeningDecorator(
    Executors.newScheduledThreadPool(8, r -> {
        Thread t = new Thread(r);
        t.setDaemon(true);
        return t;
    })
);

Many thanks for looking into this

Example code (or command)

Stacktrace

Steps to reproduce?

1. ?
2. ?
3. ?
   ...

Environment

1. OS type and version:
2. Java SDK version:
3. AlloyDB Java Connector version:

Additional Details

No response

[enocom]

Thanks for the report, @ukarlsson. This is an oversight and we'll get it fixed promptly.

[enocom]

This is fixed in v1.2.1.