Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding GMP and Cloud Monitoring for gke-batch-refarch #856

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

JamesDuncanNz
Copy link
Contributor

Adding support for GMP Managed Collection and Cloud Monitoring Dashboard for gke-batch-refarch.

Co-authored-by: Aldo Culquicondor <[email protected]>
Copy link

@laurentgrangeau laurentgrangeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, some minor changes and it should be good to go

Copy link

@laurentgrangeau laurentgrangeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arueth arueth merged commit 7c1ab76 into GoogleCloudPlatform:main Oct 28, 2024
7 checks passed
leroyjb pushed a commit to leroyjb/ai-on-gke that referenced this pull request Jan 24, 2025
…tform#856)

* Adding GMP and Cloud Monitoring for gke-batch-refarch

* Adding Images

* Apply suggestions from code review

Co-authored-by: Aldo Culquicondor <[email protected]>

* Updates to comments

---------

Co-authored-by: Aldo Culquicondor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants